Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow up to #9408 - speedreader-rust-ffi has no entry in brave://credits #9939

Closed
btlechowski opened this issue May 26, 2020 · 1 comment · Fixed by brave/brave-core#5722
Closed

Follow up to #9408 - speedreader-rust-ffi has no entry in brave://credits #9939

btlechowski opened this issue May 26, 2020 · 1 comment · Fixed by brave/brave-core#5722
Assignees
@fmarier
Labels
licensing priority/P4 Planned work. We expect to get to it "soon". QA/No release-notes/exclude
Milestone
1.11.x - Release #1

Comments

@btlechowski
Copy link

Follow up to #9408

Steps to Reproduce

  1. Open brave://flags
  2. Enable SpeedReader
  3. Open brave://credits
  4. Search for speedreader-rust-ffi

Actual result:

speedreader-rust-ffi has no entry in brave://credits

Expected result:

speedreader-rust-ffi has an entry in brave://credits
It should have a license and a working link.

Reproduces how often:

100% repro rate

Brave version (brave://version info)

Brave 1.11.25 Chromium: 81.0.4044.138 (Official Build) nightly (64-bit)
Revision 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS Windows 7 Service Pack 1 (Build 7601.24544)
Brave 1.10.71 Chromium: 81.0.4044.138 (Official Build) dev (64-bit)
Revision 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS Windows 7 Service Pack 1 (Build 7601.24544)
Brave 1.10.71 Chromium: 81.0.4044.138 (Official Build) dev (64-bit)
Revision 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS Ubuntu 18.04 LTS

cc @brave/legacy_qa @rebron @fmarier @bridiver
@btlechowski btlechowski mentioned this issue May 26, 2020
Closed
@rebron rebron added the priority/P4 Planned work. We expect to get to it "soon". label Jun 2, 2020
fmarier added a commit to brave/brave-core that referenced this issue Jun 3, 2020
@fmarier
Remove license entry for old speedreader repo (fixes brave/brave-brow…
0489fa5 
…ser#9939)

This repo was removed in 1ff745a
and merged into brave-core proper so it is covered by the main
license.
@fmarier fmarier mentioned this issue Jun 3, 2020
Merged
32 tasks
@fmarier
Copy link
Member

fmarier commented Jun 3, 2020

I can confirm that it should no longer appear in brave://credits because the old repo got removed in brave/brave-core#5142.

I will clean this up in brave/brave-core#5722.

@fmarier fmarier added this to the 1.11.x - Nightly milestone Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fmarier fmarier

Labels
licensing priority/P4 Planned work. We expect to get to it "soon". QA/No release-notes/exclude
Projects
None yet
Milestone
1.11.x - Release #1
Development

Successfully merging a pull request may close this issue.

Remove license entry for old speedreader repo brave/brave-core
3 participants
@fmarier @rebron @btlechowski