Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce licenses in third_party code added to brave-core #9408

Closed
fmarier opened this issue Apr 23, 2020 · 1 comment · Fixed by brave/brave-core#5333
Closed

Enforce licenses in third_party code added to brave-core #9408

fmarier opened this issue Apr 23, 2020 · 1 comment · Fixed by brave/brave-core#5333
Assignees
@fmarier
Labels
licensing QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.10.x - Release

Comments

@fmarier
Copy link
Member

fmarier commented Apr 23, 2020 •
edited
Loading

The licenses.py currently throws three LicenseError in src/brave/ (and then ignores them all):

  • brave/vendor/extension-whitelist
  • brave/vendor/speedreader_rust_ffi
  • brave/ui/webui/resources/fonts/third_party/crypto

The first one is a known issue and I added the missing license in brave/extension-whitelist#20 already but it was never updated in brave-core. The second was introduced in brave/brave-core#4496 and the third in brave/brave-core#5160. Only the last one is a true third-party component and needs to be fixed (tracked in #9407).

We should treat errors as fatal when they're triggered in src/brave/. Eventually, all errors will be fatal.
@fmarier fmarier self-assigned this Apr 23, 2020
fmarier added a commit to fmarier/brave-core that referenced this issue Apr 23, 2020
@fmarier
Enforce license info in src/brave (fixes brave/brave-browser#9408)
c376082 
Also see https://bugs.chromium.org/p/chromium/issues/detail?id=39240.
@fmarier fmarier mentioned this issue Apr 23, 2020
Merged
32 tasks
fmarier added a commit that referenced this issue Apr 24, 2020
@fmarier
Move LICENSE file generation to build (#9408)
38b51c4 
In order to be able to enforce the presence of licensing metadata
for everything under src/brave/, we need to ensure that all
required LICENSE files are present at build time since that's when
the upstream licenses.py script runs.

This reverts commits 1708afb,
4e7d1ee and
350ea99.
@fmarier fmarier mentioned this issue Apr 24, 2020
Merged
29 tasks
fmarier added a commit that referenced this issue Apr 24, 2020
@fmarier
Move LICENSE file generation to build (#9408)
41b5e0c 
In order to be able to enforce the presence of licensing metadata
for everything under src/brave/, we need to ensure that all
required LICENSE files are present at build time since that's when
the upstream licenses.py script runs.

This reverts commits 1708afb,
4e7d1ee and
350ea99.
fmarier added a commit to brave/brave-core that referenced this issue Apr 25, 2020
@fmarier
Enforce license info in src/brave (fixes brave/brave-browser#9408)
9780deb 
Related upstream bug: https://bugs.chromium.org/p/chromium/issues/detail?id=39240
fmarier added a commit to brave/brave-core that referenced this issue Apr 28, 2020
@fmarier
Enforce license info in src/brave (fixes brave/brave-browser#9408)
eb57b3f 
Related upstream bug: https://bugs.chromium.org/p/chromium/issues/detail?id=39240
fmarier added a commit that referenced this issue May 1, 2020
@fmarier
Move LICENSE file generation to build (#9408)
d1a8efa 
In order to be able to enforce the presence of licensing metadata
for everything under src/brave/, we need to ensure that all
required LICENSE files are present at build time since that's when
the upstream licenses.py script runs.

This reverts commits 1708afb,
4e7d1ee and
350ea99.
fmarier added a commit to brave/brave-core that referenced this issue May 1, 2020
@fmarier
Enforce license info in src/brave (fixes brave/brave-browser#9408)
b4e6cb9 
Related upstream bug: https://bugs.chromium.org/p/chromium/issues/detail?id=39240
fmarier added a commit that referenced this issue May 6, 2020
@fmarier
Move LICENSE file generation to brave-core (#9408)
e288a88
fmarier added a commit that referenced this issue May 6, 2020
@fmarier
Move LICENSE file generation to brave-core (#9408)
61b648f
fmarier added a commit to brave/brave-core that referenced this issue May 6, 2020
@fmarier
Enforce license info in src/brave (fixes brave/brave-browser#9408)
6311293 
Related upstream bug: https://bugs.chromium.org/p/chromium/issues/detail?id=39240
fmarier added a commit that referenced this issue May 7, 2020
@fmarier
Move LICENSE file generation to brave-core (#9408)
3b2ba39
fmarier added a commit to brave/brave-core that referenced this issue May 8, 2020
@fmarier
Enforce license info in src/brave (fixes brave/brave-browser#9408)
aa7b503 
Related upstream bug: https://bugs.chromium.org/p/chromium/issues/detail?id=39240
fmarier added a commit that referenced this issue May 12, 2020
@fmarier
Move LICENSE file generation to brave-core (#9408)
c6f90b9
fmarier added a commit that referenced this issue May 13, 2020
@fmarier
Move LICENSE file generation to brave-core (#9408)
1431501
fmarier added a commit to brave/brave-core that referenced this issue May 13, 2020
@fmarier
Enforce license info in src/brave (fixes brave/brave-browser#9408)
f020ffb 
Related upstream bug: https://bugs.chromium.org/p/chromium/issues/detail?id=39240
@fmarier fmarier added this to the 1.10.x - Nightly milestone May 14, 2020
@btlechowski btlechowski mentioned this issue May 26, 2020
Closed
@btlechowski
Copy link

btlechowski commented May 26, 2020 •
edited by LaurenWags
Loading

Verification passed on

Brave 1.10.71 Chromium: 81.0.4044.138 (Official Build) dev (64-bit)
Revision 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#5333

Verified that following entries have a license and a working link:

Brave background images
image
extension-whitelist
image

speedreader-rust-ffi has no entry in brave://credits. Logged #9939

Verification passed on

Brave | 1.10.71 Chromium: 81.0.4044.138 (Official Build) dev (64-bit)
-- | --
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | Windows 10 OS Version 1803 (Build 17134.1006)

Brave background images
image
extension-whitelist
image

Verified passed with

Brave | 1.10.79 Chromium: 81.0.4044.138 (Official Build) dev (64-bit)
-- | --
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | macOS Version 10.14.6 (Build 18G3020)

Brave background images
Screen Shot 2020-06-01 at 9 37 39 AM

extension-whitelist
Screen Shot 2020-06-01 at 9 38 04 AM

Encountered #9939

petemill pushed a commit to brave/brave-core that referenced this issue Jul 27, 2020
@fmarier
Move LICENSE file generation to brave-core (brave/brave-browser#9408)
71d5daf
petemill pushed a commit to brave/brave-core that referenced this issue Jul 28, 2020
@fmarier
Move LICENSE file generation to brave-core (brave/brave-browser#9408)
db0e2d3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fmarier fmarier

Labels
licensing QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.10.x - Release
Development

Successfully merging a pull request may close this issue.

Enforce licenses in third_party code added to brave-core brave/brave-core
4 participants
@fmarier @LaurenWags @btlechowski @GeetaSarvadnya