Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move LICENSE file generation to build #9461

Merged
merged 1 commit into from
May 14, 2020

Conversation

fmarier
Copy link
Member

@fmarier fmarier commented Apr 24, 2020

This is now required in order to address #9408.

Submitter Checklist:

Test Plan:

See brave/brave-core#5333.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions.

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@fmarier fmarier requested a review from bridiver April 24, 2020 23:33
@fmarier fmarier self-assigned this Apr 24, 2020
@fmarier fmarier force-pushed the enforce_missing_brave_licenses-9408 branch 2 times, most recently from 41b5e0c to d1a8efa Compare May 1, 2020 00:31
@fmarier fmarier force-pushed the enforce_missing_brave_licenses-9408 branch 3 times, most recently from 61b648f to 3b2ba39 Compare May 7, 2020 22:43
bridiver
bridiver previously approved these changes May 8, 2020
@fmarier fmarier force-pushed the enforce_missing_brave_licenses-9408 branch from c6f90b9 to 1431501 Compare May 13, 2020 18:36
@fmarier fmarier requested a review from bridiver May 14, 2020 01:05
@fmarier fmarier merged commit 6a86483 into master May 14, 2020
@fmarier fmarier deleted the enforce_missing_brave_licenses-9408 branch May 14, 2020 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants