Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy brave_privacy_page resource folder for WebRTC policy setting #1389

Merged
merged 1 commit into from
Oct 2, 2018
Merged

Copy brave_privacy_page resource folder for WebRTC policy setting #1389

merged 1 commit into from
Oct 2, 2018

Conversation

yrliou
Copy link
Member

@yrliou yrliou commented Oct 2, 2018 •
edited
Loading

Requires brave/brave-core#538
Fix #551

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Requested a security/privacy review as needed.

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions.

@yrliou yrliou self-assigned this Oct 2, 2018
@yrliou yrliou mentioned this pull request Oct 2, 2018
Merged
11 tasks
@yrliou yrliou merged commit 3e90d97 into master Oct 2, 2018
yrliou added a commit that referenced this pull request Oct 2, 2018
@yrliou
Merge pull request #1389 from brave/webrtc_policy_setting
36cd9ef 
Copy brave_privacy_page resource folder for WebRTC policy setting
yrliou added a commit that referenced this pull request Oct 2, 2018
@yrliou
Merge pull request #1389 from brave/webrtc_policy_setting
8adb57c 
Copy brave_privacy_page resource folder for WebRTC policy setting
@yrliou
Copy link
Member Author

yrliou commented Oct 2, 2018

master: 3e90d97
0.55.x: 36cd9ef
0.56.x: 8adb57c

@yrliou yrliou deleted the webrtc_policy_setting branch October 2, 2018 18:11
@bbondy bbondy removed the 0.55.x label Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbondy bbondy bbondy approved these changes

@simonhong simonhong Awaiting requested review from simonhong

Assignees

@yrliou yrliou

Labels
None yet
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
Development

Successfully merging this pull request may close these issues.
2 participants
@yrliou @bbondy