Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add WebRTC IP handling policy setting in the privacy page #538

Merged
merged 2 commits into from
Oct 2, 2018
Merged

Add WebRTC IP handling policy setting in the privacy page #538

merged 2 commits into from
Oct 2, 2018

Conversation

yrliou
Copy link
Member

@yrliou yrliou commented Oct 2, 2018 •
edited
Loading

Close brave/brave-browser#551
Requires brave/brave-browser#1389

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

(Copy the test plan from brave/browser-laptop#13713)

  1. Go to chrome://settings/privacy
    It should show a webrtc policy select menu which defaults to 'default'
  2. Turn on fingerprinting protection to 'block all' and visit https://browserleaks.com/webrtc.
    It should not show any IPs
  3. Turn off fingerprinting protection on that page, now it should show IPs.
  4. Set webrtc policy to 'default public interface only' in chrome://settings/privacy
  5. Reload https://browserleaks.com/webrtc. It should only show the public IP.
  6. Set webrtc policy to 'disable non-proxied UDP' in chrome://settings/privacy
  7. Reload https://browserleaks.com/webrtc. It should show no IPs.
  8. Set webrtc policy to 'default public and private interfaces' in chrome://settings/privacy
  9. Reload https://browserleaks.com/webrtc. It should show both IPs.

UI Screenshot:
screen shot 2018-10-01 at 7 38 37 pm

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@yrliou yrliou self-assigned this Oct 2, 2018
@yrliou yrliou changed the title Add WebRTC IP handling policy setting in the privacy page WIP: Add WebRTC IP handling policy setting in the privacy page Oct 2, 2018
@yrliou yrliou changed the title WIP: Add WebRTC IP handling policy setting in the privacy page Add WebRTC IP handling policy setting in the privacy page Oct 2, 2018
@yrliou yrliou mentioned this pull request Oct 2, 2018
Merged
16 tasks
@yrliou yrliou force-pushed the webrtc_policy_setting branch from 1f6bbcd to c110824 Compare October 2, 2018 03:00
@yrliou yrliou requested review from bbondy and simonhong October 2, 2018 03:00
@yrliou yrliou force-pushed the webrtc_policy_setting branch from c110824 to 3a33d4e Compare October 2, 2018 05:58
bbondy
bbondy reviewed Oct 2, 2018
View reviewed changes
script/chromium-rebase-l10n.py
brave_privacy_page_browser_proxy_js_element.set('type', 'chrome_html')
brave_privacy_page_browser_proxy_js_element.set('preprocess', 'true')
brave_privacy_page_browser_proxy_html_element = xml_tree.xpath('//structure[@name="IDR_SETTINGS_BRAVE_PRIVACY_PAGE_BROWSER_PROXY_HTML"]')[0]
brave_privacy_page_browser_proxy_html_element.addnext(brave_privacy_page_browser_proxy_js_element)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noting this is in need of some refactoring, or we should pull everything into 1 template html and JS page maybe that references other things. But not in the context of this issue.

@yrliou yrliou merged commit ee4561e into master Oct 2, 2018
yrliou added a commit that referenced this pull request Oct 2, 2018
@yrliou
Merge pull request #538 from brave/webrtc_policy_setting
f737248 
Add WebRTC IP handling policy setting in the privacy page
yrliou added a commit that referenced this pull request Oct 2, 2018
@yrliou
Merge pull request #538 from brave/webrtc_policy_setting
3864efe 
Add WebRTC IP handling policy setting in the privacy page
@yrliou
Copy link
Member Author

yrliou commented Oct 2, 2018

master: ee4561e
0.55.x: f737248
0.56.x: 3864efe

@yrliou yrliou mentioned this pull request Oct 2, 2018
Closed
@yrliou yrliou deleted the webrtc_policy_setting branch October 2, 2018 18:10
@bbondy bbondy added this to the 0.55.x - Release milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbondy bbondy bbondy approved these changes

@simonhong simonhong Awaiting requested review from simonhong

Assignees

@yrliou yrliou

Labels
None yet
Projects
None yet
Milestone
0.55.x - Release
Development

Successfully merging this pull request may close these issues.

Add switch to disable WebRTC
3 participants
@yrliou @bridiver @bbondy