-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add note about user namespaces to linux doc #2813
Conversation
needed for #1986 mostly ported over from https://github.com/brave/browser-laptop/blob/master/docs/linuxInstall.md
Fix brave/brave-browser#1986 Depends on brave/brave-browser#2813 Ported from brave/muon#171
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
I've posted in a related issue, but I wanted to repost here: I'm concerned about the way in which this Issue was closed... User name spaces are explicitly disabled in many Linux distros, because they increase the risk for local kernel escalation. Again, see my post from the Arch Linux docs:
https://wiki.archlinux.org/index.php/security Simply telling people to lower the security of their OS seems irresponsible and concerning. Is there no other real solution in the works? |
Also, the link in the commit isn't even the right instructions for people on many distros. For example, on Arch or Manjaro, the command would be: sudo sysctl kernel.unprivileged_userns_clone=1 But again, this is reducing the security of the user's OS. We need a real sandboxing solution. |
@bbondy Would you mind taking a look at this? I know you've been focused on security things the past few days. |
Thanks @jacobcantele, would you mind posting an issue on this repo with the above. I searched to see if there was one already but I didn't see one. |
Yes, you got it. |
needed for #1986
mostly ported over from
https://github.com/brave/browser-laptop/blob/master/docs/linuxInstall.md
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests
) ongit rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist: