Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert Chromium 74 from master #3896

Merged
merged 3 commits into from
Mar 27, 2019
Merged

Revert Chromium 74 from master #3896

merged 3 commits into from
Mar 27, 2019

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented Mar 26, 2019

DO NOT MERGE UNLESS CI PASSES

Related brave/brave-core#2079
Reverts:

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests && npm run test-security) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Requested a security/privacy review as needed.

Test Plan:

  1. Go into Jenkins for this PR
  2. Verify everything passes on all platforms
  3. If anything fails, don't merge

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions.

@bsclifton bsclifton self-assigned this Mar 26, 2019
@bsclifton bsclifton added this to the 0.64.x - Nightly milestone Mar 26, 2019
(originally implemented with #3790)

Fixes #3898
@bsclifton bsclifton requested a review from rebron March 27, 2019 01:36
@bsclifton bsclifton marked this pull request as ready for review March 27, 2019 01:36
@bsclifton bsclifton changed the title WIP: Revert c74 Revert Chromium 74 from master Mar 27, 2019
@bbondy bbondy merged commit 25a0ea7 into master Mar 27, 2019
@mihaiplesa mihaiplesa deleted the revert-c74 branch March 27, 2019 15:10
@jumde jumde mentioned this pull request Mar 27, 2019
19 tasks
mkarolin added a commit that referenced this pull request Mar 28, 2019
Reland C74 on master.

This reverts commit 25a0ea7, reversing
changes made to bd47a7f.
mkarolin added a commit that referenced this pull request Mar 28, 2019
Reland C74 on master.

This reverts commit 25a0ea7, reversing
changes made to bd47a7f.
mkarolin added a commit that referenced this pull request Apr 1, 2019
Reland C74 on master.

This reverts commit 25a0ea7, reversing
changes made to bd47a7f.
mkarolin added a commit that referenced this pull request Apr 2, 2019
Reland C74 on master.

This reverts commit 25a0ea7, reversing
changes made to bd47a7f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chromium 74 update is breaking nightly build
3 participants