-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 8683: Use GetAffectedFiles instead of GetChange #8684
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihaiplesa
approved these changes
Mar 13, 2020
bsclifton
approved these changes
Mar 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
This was referenced Mar 13, 2020
Merged
jumde
pushed a commit
that referenced
this pull request
Mar 13, 2020
Fix 8683: Use GetAffectedFiles instead of GetChange
4 tasks
29 tasks
4 tasks
jumde
pushed a commit
that referenced
this pull request
Mar 13, 2020
Fix 8683: Use GetAffectedFiles instead of GetChange
29 tasks
This was referenced Mar 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #8683
Submitter Checklist:
git rebase master
(if needed).git rebase -i
to squash commits (if needed).added to
scripts/audit.js
.Test Plan:
npm run lint
to confirm no errors on lintReviewer Checklist:
After-merge Checklist:
changes has landed on.