Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 8683: Use GetAffectedFiles instead of GetChange #8684

Merged
merged 1 commit into from
Mar 13, 2020

Conversation

jumde
Copy link
Contributor

@jumde jumde commented Mar 13, 2020

Fix #8683

Submitter Checklist:

Test Plan:

  1. Run npm run lint to confirm no errors on lint

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions.

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@jumde jumde self-assigned this Mar 13, 2020
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@mihaiplesa mihaiplesa merged commit 4058e6d into master Mar 13, 2020
@mihaiplesa mihaiplesa deleted the getChange_getAffectedFiles branch March 13, 2020 17:17
jumde pushed a commit that referenced this pull request Mar 13, 2020
Fix 8683: Use GetAffectedFiles instead of GetChange
jumde pushed a commit that referenced this pull request Mar 13, 2020
Fix 8683: Use GetAffectedFiles instead of GetChange
@jumde jumde added this to the 1.8.x - Nightly milestone Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lint failing with depot_tools update
3 participants