Merge pull request #8143 from /issues/14447-1.22.x

Fixed crash when fetching Rewards Widget estimated earnings - 1.22.x
brave · Mar 9, 2021 · 3d5b13d · 3d5b13d
2 parents 677dbc3 + 7b91424
commit 3d5b13d
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/browser/extensions/api/brave_rewards_api.cc b/browser/extensions/api/brave_rewards_api.cc
@@ -1137,7 +1137,9 @@ BraveRewardsGetAdsEstimatedEarningsFunction::Run() {
     return RespondNow(Error("Ads service is not initialized"));
   }
 
-  ads_service_->GetStatement(base::Bind(
+  AddRef();  // Balanced in OnAdsEstimatedEarnings().
+
+  ads_service_->GetStatement(base::BindOnce(
       &BraveRewardsGetAdsEstimatedEarningsFunction::OnAdsEstimatedEarnings,
       this));
   return RespondLater();
@@ -1151,6 +1153,8 @@ void BraveRewardsGetAdsEstimatedEarningsFunction::OnAdsEstimatedEarnings(
     const double earnings_this_month,
     const double earnings_last_month) {
   Respond(OneArgument(base::Value(estimated_pending_rewards)));
+
+  Release();  // Balanced in Run()
 }
 
 BraveRewardsGetAdsSupportedFunction::