Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed crash when fetching Rewards Widget estimated earnings - 1.22.x #8143

Merged
merged 1 commit into from
Mar 9, 2021

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Mar 5, 2021

Uplift of #8114
Resolves brave/brave-browser#14447

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@tmancey tmancey requested a review from a team March 5, 2021 14:46
@tmancey tmancey self-assigned this Mar 5, 2021
@tmancey tmancey added this to the 1.22.x - Beta milestone Mar 5, 2021
@kjozwiak
Copy link
Member

kjozwiak commented Mar 9, 2021

Restarting pre-init due to the following failure:

[2021-03-05T14:56:43.342Z] Searching s3://**** for object:'brave-browser-build-pr/issues/14447-1.22.x/1/windows/build-status.txt'
[2021-03-05T14:56:43.397Z] Search complete
groovy.lang.MissingPropertyException: No such property: FAILED_STAGE for class: Script1

Restarting macOS due to build failing as per https://ci.brave.com/job/pr-brave-browser-issues-14447-1.22.x-macos/1/execution/node/165/log/

13:55:34  FAILED: obj/third_party/blink/renderer/platform/loader/loader/subresource_integrity.o 

post-init failed audit_deps due to a known failure as per https://ci.brave.com/job/pr-brave-browser-issues-14447-1.22.x-post-init/1/execution/node/145/log. However, the failure isn't related to this particular PR and doesn't block uplift.

@kjozwiak
Copy link
Member

kjozwiak commented Mar 9, 2021

Restarting macOS due to build failing as per https://ci.brave.com/job/pr-brave-browser-issues-14447-1.22.x-macos/2/execution/node/165/log/.

00:12:31  FAILED: obj/brave/common/extensions/api/generated_api_registration/generated_api_registration.o 

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.22.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #8114 (comment).

@kjozwiak kjozwiak merged commit 3d5b13d into 1.22.x Mar 9, 2021
@kjozwiak kjozwiak deleted the issues/14447-1.22.x branch March 9, 2021 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants