Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed crash when fetching Rewards Widget estimated earnings #8114

Merged
merged 1 commit into from
Mar 5, 2021

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Mar 3, 2021

Resolves brave/brave-browser#14447

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Confirm Rewards Widget estimated earnings are updated after a fresh install
  • Confirm Rewards Widget estimated earnings are updated after viewing at least 1 ad
  • Confirm Rewards Widget estimated earnings are updated after refreshing a new tab page
  • Confirm "Restarting ads service" does not appear in the console logs

@tmancey tmancey requested review from moritzhaller and emerick March 3, 2021 12:52
@tmancey tmancey self-assigned this Mar 3, 2021
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@moritzhaller moritzhaller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmancey
Copy link
Collaborator Author

tmancey commented Mar 5, 2021

CI failed for known audit dep issue

@tmancey tmancey merged commit 506e17c into master Mar 5, 2021
@tmancey tmancey deleted the issues/14447 branch March 5, 2021 16:06
@tmancey tmancey added this to the 1.23.x - Nightly milestone Mar 5, 2021
@kjozwiak
Copy link
Member

kjozwiak commented Mar 9, 2021

Verification PASSED on Win 10 x64 using the following build:

Brave | 1.23.24 Chromium: 89.0.4389.82 (Official Build) nightly (64-bit)
-- | --
Revision | 8d785cc4e2b89bff35f6a21710215271fb8fd782-refs/branch-heads/4389@{#1433}
OS | Windows 10 OS Version 2009 (Build 19042.844)
  • ensured that clicking on Startg using Rewards via brave://newtab works as expected
  • ensured that estiamted earnings is being updated in a previously opened brave://newtab after viewing an ad
  • ensured that the correct estimated earnings is being displayed when opening a new brave://newtab after viewing an ad
  • ensured that refreshing brave://newtab right after viewing an ad doesn't crash Brave and updates estiamted earnings correctly
  • ensured that that estimated earnings under brave://rewards match the value that's being displayed under brave://newtab
  • ensured that Restarting ads service isn't appearing in the CLI/terminal logs

However, ran into brave/brave-browser#14143 while running through the above which appears to be a known issue and not a new regression due to the above PR.

@tmancey
Copy link
Collaborator Author

tmancey commented Mar 9, 2021

@kjozwiak I did not see the above ticket as it was assigned to the rewards project, however I have closed brave/brave-browser#14143 as it is a duplicate of brave/brave-browser#13267

kylehickinson pushed a commit that referenced this pull request Jan 4, 2024
* Refactor `SwapTransactionConfirmationView` into `SaferSignTransactionContainerView` & `SaferSignTransactionView`, remove dependency on `ParsedTransaction` for re-use by Sign panel.

* Add SaferSignMessageRequestContainerView & `SignMessageRequestStore` for Safer Sign CoW swaps in Signature Requests.

* Refactor `SignMessageRequestContentView` out of `SignMessageRequestView` for re-use. Update `SaferSignMessageRequestContainerView` to use `SignMessageRequestContentView` for details view display.

* Add explorer url button to tokens in `SaferSignTransactionView`

* Address review comment; always show receiving address in safer sign even when it's same as from address/account.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix crash when fetching Rewards Widget estimated earnings
5 participants