-
Notifications
You must be signed in to change notification settings - Fork 895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed crash when fetching Rewards Widget estimated earnings #8114
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
CI failed for known audit dep issue |
Verification PASSED on
However, ran into brave/brave-browser#14143 while running through the above which appears to be a known issue and not a new regression due to the above PR. |
@kjozwiak I did not see the above ticket as it was assigned to the rewards project, however I have closed brave/brave-browser#14143 as it is a duplicate of brave/brave-browser#13267 |
* Refactor `SwapTransactionConfirmationView` into `SaferSignTransactionContainerView` & `SaferSignTransactionView`, remove dependency on `ParsedTransaction` for re-use by Sign panel. * Add SaferSignMessageRequestContainerView & `SignMessageRequestStore` for Safer Sign CoW swaps in Signature Requests. * Refactor `SignMessageRequestContentView` out of `SignMessageRequestView` for re-use. Update `SaferSignMessageRequestContainerView` to use `SignMessageRequestContentView` for details view display. * Add explorer url button to tokens in `SaferSignTransactionView` * Address review comment; always show receiving address in safer sign even when it's same as from address/account.
Resolves brave/brave-browser#14447
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: