Tokens are not redeemed for viewed Ads at server side when passing --…

…rewards=debug=true command-line arg Fixes brave/brave-browser#4186
brave · Apr 23, 2019 · 523ef68 · 523ef68
1 parent 185dbf7
commit 523ef68
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 15 deletions.
diff --git a/vendor/bat-native-confirmations/src/bat/confirmations/internal/confirmations_impl.cc b/vendor/bat-native-confirmations/src/bat/confirmations/internal/confirmations_impl.cc
@@ -883,26 +883,16 @@ void ConfirmationsImpl::RefillTokensIfNecessary() const {
 }
 
 uint64_t ConfirmationsImpl::CalculateTokenRedemptionTimeInSeconds() {
-  auto now_in_seconds = Time::NowInSeconds();
-
-  uint64_t start_timer_in;
-
-  if (_is_debug) {
-    if (next_token_redemption_date_in_seconds_ - now_in_seconds >=
-        kDebugNextTokenRedemptionAfterSeconds) {
-      UpdateNextTokenRedemptionDate();
-      SaveState();
-    }
-  }
-
   if (next_token_redemption_date_in_seconds_ == 0) {
     UpdateNextTokenRedemptionDate();
-    SaveState();
   }
 
+  auto now_in_seconds = Time::NowInSeconds();
+
+  uint64_t start_timer_in;
   if (now_in_seconds >= next_token_redemption_date_in_seconds_) {
     // Browser was launched after the token redemption date
-    start_timer_in = base::RandInt(0, 5 * base::Time::kSecondsPerMinute);
+    start_timer_in = base::RandInt(0, 1 * base::Time::kSecondsPerMinute);
   } else {
     start_timer_in = next_token_redemption_date_in_seconds_ - now_in_seconds;
   }
@@ -923,6 +913,8 @@ void ConfirmationsImpl::UpdateNextTokenRedemptionDate() {
     next_token_redemption_date_in_seconds_ +=
         kDebugNextTokenRedemptionAfterSeconds;
   }
+
+  SaveState();
 }
 
 void ConfirmationsImpl::StartRetryingFailedConfirmations(

diff --git a/vendor/bat-native-confirmations/src/bat/confirmations/internal/payout_tokens.cc b/vendor/bat-native-confirmations/src/bat/confirmations/internal/payout_tokens.cc
@@ -129,7 +129,6 @@ void PayoutTokens::OnPayout(const Result result) {
 
 void PayoutTokens::ScheduleNextPayout() const {
   confirmations_->UpdateNextTokenRedemptionDate();
-  confirmations_->SaveState();
 
   auto start_timer_in = confirmations_->CalculateTokenRedemptionTimeInSeconds();
   confirmations_->StartPayingOutRedeemedTokens(start_timer_in);