Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tokens are not redeemed for viewed Ads at server side when passing --rewards=debug=true command-line arg #4186

Closed
GeetaSarvadnya opened this issue Apr 22, 2019 · 3 comments · Fixed by brave/brave-core#2300

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Apr 22, 2019

Description

Found while testing #3659
Tokens are not redeemed for viewed Ads at server side

Steps to Reproduce

  1. Clean profile 0.63.46
  2. Launch the browser through command line using C:\Program Files (x86)\BraveSoftware\Brave-Browser\Application\brave.exe --enable-logging --log-level=2 --vmodule=brave_ads=3 --brave-ads-production --rewards=staging=false --rewards=debug=true
  3. View a couple of Ads
  4. Close the browser
  5. Wait for 25 mins
  6. Relaunch browser
  7. Verify console logs
  8. Tokens are not redeemed for viewed ads

Actual result:

Redeemed token records are empty at the server side

Payment id: "5c53d8f3-0bd4-4830-a7e9-b5bb96e60b61"

chrome_debug.log

Expected result:

Redeemed token records should be available in DB table

Reproduces how often:

Always

Brave version (brave://version info)

Brave 0.63.46 Chromium: 74.0.3729.91 (Official Build) (64-bit)
Revision 03844ed83e02b8add3f4b9cb859a7108d55b2e4d-refs/branch-heads/3729@{#860}
OS Windows 10 OS Build 17134.523

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? No
  • Can you reproduce this issue with the dev channel? Not verified
  • Can you reproduce this issue with the nightly channel? Not verified

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards?NA
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@amirsaber: Thanks for checking records at the server side
@brave/legacy_qa @tmancey

@GeetaSarvadnya GeetaSarvadnya changed the title Tokens are not redeemed for viewed Ads at server side On Release version tokens are not redeemed for viewed Ads at server side Apr 22, 2019
@tmancey tmancey changed the title On Release version tokens are not redeemed for viewed Ads at server side Tokens are not redeemed for viewed Ads at server side when passing --rewards=debug=true command-line arg Apr 22, 2019
@tmancey
Copy link
Contributor

tmancey commented Apr 22, 2019

Steps to reproduce (on any platform across all build channels)

  • Launch browser with --rewards=debug=true command-line arg
  • View some Ads
  • Close the browser
  • Wait for ~25 minutes
  • Launch the browser

Expected result:

Tokens are redeemed with the Ads service

Actual result:

Tokens are not redeemed and the timer resets to ~25 minutes

NOTES: If the user does not close the browser tokens are redeemed.

@GeetaSarvadnya can you please confirm and update the steps in the description

@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented Apr 22, 2019

@tmancey Steps are updated. The issue is arising when we use --rewards=debug=true flag and close the browser after viewing ads.

tmancey added a commit to brave/brave-core that referenced this issue Apr 23, 2019
tmancey added a commit to brave/brave-core that referenced this issue Apr 23, 2019
@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented May 3, 2019

Verification passed on

Brave 0.64.68 Chromium: 74.0.3729.108 (Official Build) beta (64-bit)
Revision daaff52abef89988bf2a26091062160b1482b108-refs/branch-heads/3729@{#901}
OS Windows 10 OS Build 17134.523
  • Verified the STR mentioned in the description

Verified passed with

Brave 0.64.72 Chromium: 74.0.3729.131 (Official Build) beta(64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Mac OS X
  • Verified STR from description

Verified passed with

Brave 0.64.75 Chromium: 74.0.3729.131 (Official Build) beta(64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Linux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment