Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tokens are not redeemed for viewed Ads at server side when passing --rewards=debug=true command-line arg 0.64.x #2302

Merged
merged 1 commit into from
Apr 23, 2019
Merged

Fix tokens are not redeemed for viewed Ads at server side when passing --rewards=debug=true command-line arg 0.64.x #2302

merged 1 commit into from
Apr 23, 2019

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Apr 22, 2019

Uplift for #2300
Fixes brave/brave-browser#4186

@tmancey tmancey added this to the 0.64.x - Beta milestone Apr 22, 2019
@tmancey tmancey requested a review from a team April 22, 2019 13:48
@tmancey tmancey self-assigned this Apr 22, 2019
@tmancey
Copy link
Collaborator Author

tmancey commented Apr 22, 2019

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they're landing to.

@tmancey tmancey marked this pull request as ready for review April 22, 2019 21:43
rebron
rebron approved these changes Apr 22, 2019
View reviewed changes
Copy link
Collaborator

@rebron rebron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving per discussion with @srirambv

@tmancey tmancey merged commit 523ef68 into 0.64.x Apr 23, 2019
@tmancey tmancey deleted the issues/4186-0.64.x branch April 23, 2019 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rebron rebron rebron approved these changes

Assignees

@tmancey tmancey

Labels
bug feature/ads feature/rewards
Projects
None yet
Milestone
0.64.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@tmancey @rebron