Merge pull request #947 from /issues/2213

correctly delete fetchers
brave · Nov 22, 2018 · c8e55c3 · c8e55c3
1 parent c4975cc
commit c8e55c3
Showing 1 changed file with 10 additions and 1 deletion.
diff --git a/components/brave_rewards/browser/rewards_service_impl.cc b/components/brave_rewards/browser/rewards_service_impl.cc
@@ -516,7 +516,11 @@ void RewardsServiceImpl::Shutdown() {
     }
   }
 
+  for (const auto fetcher : fetchers_) {
+    delete fetcher.first;
+  }
   fetchers_.clear();
+
   ledger_.reset();
   RewardsService::Shutdown();
 }
@@ -868,11 +872,14 @@ std::unique_ptr<ledger::LedgerURLLoader> RewardsServiceImpl::LoadURL(
 
 void RewardsServiceImpl::OnURLFetchComplete(
     const net::URLFetcher* source) {
-  if (fetchers_.find(source) == fetchers_.end())
+  if (fetchers_.find(source) == fetchers_.end()) {
+    delete source;
     return;
+  }
 
   auto callback = fetchers_[source];
   fetchers_.erase(source);
+
   int response_code = source->GetResponseCode();
   std::string body;
   std::map<std::string, std::string> headers;
@@ -893,6 +900,8 @@ void RewardsServiceImpl::OnURLFetchComplete(
     source->GetResponseAsString(&body);
   }
 
+  delete source;
+
   callback.Run(response_code, body, headers);
 }