Merge pull request #3276 from brave/sandbox_uphold_exception

Issue 5800: Add a fingerprint exception for sandbox.uphold.com
brave · Aug 28, 2019 · d18e225 · d18e225
2 parents e37c2a1 + 06b2551
commit d18e225
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 0 deletions.
diff --git a/common/shield_exceptions.cc b/common/shield_exceptions.cc
@@ -45,6 +45,11 @@ bool IsWhitelistedFingerprintingException(const GURL& firstPartyOrigin,
       GURL("https://uphold.com/"),
       std::vector<URLPattern>({URLPattern(URLPattern::SCHEME_ALL,
             "https://uphold.netverify.com/*")})
+    },
+    {
+      GURL("https://sandbox.uphold.com/"),
+      std::vector<URLPattern>({URLPattern(URLPattern::SCHEME_ALL,
+            "https://netverify.com/*")})
     }
   };
   std::map<GURL, std::vector<URLPattern> >::iterator i =

diff --git a/common/shield_exceptions_unittest.cc b/common/shield_exceptions_unittest.cc
@@ -46,6 +46,29 @@ TEST_F(BraveShieldsExceptionsTest, IsWhitelistedFingerprintingException) {
   EXPECT_FALSE(IsWhitelistedFingerprintingException(
       GURL("https://www.uphold.com/"),
       GURL("https://uphold.netverify.com/iframe")));
+
+  // Tests for sandbox URLs
+  EXPECT_TRUE(IsWhitelistedFingerprintingException(
+      GURL("https://sandbox.uphold.com"),
+      GURL("https://netverify.com/iframe")));
+  EXPECT_TRUE(IsWhitelistedFingerprintingException(
+      GURL("https://sandbox.uphold.com/"),
+      GURL("https://netverify.com")));
+  EXPECT_FALSE(IsWhitelistedFingerprintingException(
+      GURL("http://sandbox.uphold.com/"),
+      GURL("https://uphold.netverify.com/")));
+  EXPECT_FALSE(IsWhitelistedFingerprintingException(
+      GURL("https://sandbox.uphold.com/"),
+      GURL("http://netverify.com/")));
+  EXPECT_FALSE(IsWhitelistedFingerprintingException(
+      GURL("https://netverify.com/iframe"),
+      GURL("https://sandbox.uphold.com/")));
+  EXPECT_FALSE(IsWhitelistedFingerprintingException(
+      GURL("https://sandbox.uphold.com/"),
+      GURL("https://uphold.netverify.com/iframe")));
+  EXPECT_FALSE(IsWhitelistedFingerprintingException(
+      GURL("https://www.sandbox.uphold.com/"),
+      GURL("https://netverify.com/iframe")));
 }
 
 }  // namespace