Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 5800: Add a fingerprint exception for sandbox.uphold.com #3276

Merged
merged 1 commit into from
Aug 28, 2019

Conversation

jumde
Copy link
Contributor

@jumde jumde commented Aug 28, 2019

Fix brave/brave-browser#5800

Submitter Checklist:

Test Plan:

  1. Navigate to https://sandbox.uphold.com
  2. Create an account and initiate verification.
  3. Enter your address > Next > Upload Driver's license
  4. Upload your driver's license.
  5. Navigate to brave shields and verify that no fingerprinting requests are blocked (Cross Site Device Recognition blocked)

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@jumde jumde self-assigned this Aug 28, 2019
Copy link
Member

@diracdeltas diracdeltas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm assuming tests pass!

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😄👍

@LaurenWags
Copy link
Member

LaurenWags commented Aug 28, 2019

The following tests were done using 0.71.44 on Nightly (macOS):

  1. Launched clean profile with 0.71.44 with staging parameter. Enabled Rewards, followed 'verify wallet' prompts to get to sandbox Uphold site. Created a fake profile. Verified I was able to submit documents for KYC without issue.
  2. Launched clean profile with 0.71.44. Enabled Rewards, followed 'verify wallet' prompts to get to prod Uphold site. Created a fake profile. Verified I was able to submit documents for KYC without issue.
  3. Launched clean profile with 0.68.132 with staging parameter. Enabled Rewards. Navigated to sandbox Uphold site. Created a fake profile. Verified I was unable to submit documents for KYC (FP on default shields is stopping me). Renamed profile to Nightly and launched with 0.71.44. Verified I was now able to submit documents for KYC without issue.
  4. Launched clean profile with 0.68.132. Enabled Rewards. Navigated to prod Uphold site. Created a fake profile. Verified I was unable to submit documents for KYC (FP on default shields is stopping me). Renamed profile to Nightly and launched with 0.71.44. Verified I was now able to submit documents for KYC without issue.

In all cases above I wasn't going for actual KYC so I didn't use real docs, but using 0.71.44 I did not encounter any FP issues which prevented me from uploading photos. I did encounter the autoplay issue @jumde found only once on 0.71.44 and was unable to reproduce again.

@pj
Copy link

pj commented Aug 28, 2019

Hi guys, wrong @pj! 😂

@LaurenWags
Copy link
Member

ack, sorry (wrong) @pj - thought I removed that. apologies!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

default shield prevents uploading image for Uphold KYC
5 participants