Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 5800: Add a fingerprint exception for sandbox.uphold.com (uplift to 0.69.x) #3278

Merged
merged 1 commit into from
Aug 30, 2019

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Aug 28, 2019

Uplift of #3276
Fixes brave/brave-browser#5800

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds self-assigned this Aug 28, 2019
@brave-builds brave-builds added this to the 0.69.x - Beta milestone Aug 28, 2019
@bsclifton bsclifton requested review from a team and removed request for bbondy, kjozwiak, bsclifton, rebron and srirambv August 28, 2019 05:10
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving after convo with @LaurenWags and @rebron. CI did have one failure (macOS browser tests) but I took a look and this is an intermittent issue (not related to this PR)

@bsclifton bsclifton merged commit c620e19 into 0.69.x Aug 30, 2019
@bsclifton bsclifton deleted the pr3276_sandbox_uphold_exception_0.69.x branch August 30, 2019 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants