Merge pull request #658 from brave/maxk-fix-crash-downloading

Fixes crashes when downloading an item (repro'd with a .crx)
brave · Oct 17, 2018 · daf9c85 · daf9c85
1 parent 4a26b81
commit daf9c85
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/browser/ui/views/download/brave_download_item_view.cc b/browser/ui/views/download/brave_download_item_view.cc
@@ -81,7 +81,9 @@ void BraveDownloadItemView::OnDownloadUpdated(
   download::DownloadItem* download) {
   // Check for conditions that would disregard origin url change and fall back
   // onto base implementation to handle them.
-  if (!model_.ShouldShowInShelf()) {
+  if (!model_.ShouldShowInShelf() ||
+      (DownloadItemView::download()->GetState() == DownloadItem::COMPLETE &&
+       model_.ShouldRemoveFromShelfWhenComplete())) {
     DownloadItemView::OnDownloadUpdated(download);
     return;
   }