Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes crashes when downloading an item (repro'd with a .crx) #658

Merged
merged 1 commit into from
Oct 17, 2018

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented Oct 17, 2018

Fixes crashes when downloading an item due to using BraveDownloadItemView after it is deleted by the base class on download completion.

Fixes brave/brave-browser#1628

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

use BraveDownloadItemView after it is deleted by the base class on
download completion.

Fixes brave/brave-browser#1628
@mkarolin mkarolin self-assigned this Oct 17, 2018
@mkarolin mkarolin requested a review from bbondy October 17, 2018 03:47
@bbondy bbondy merged commit 7e4770a into master Oct 17, 2018
bbondy added a commit that referenced this pull request Oct 17, 2018
Fixes crashes when downloading an item (repro'd with a .crx)
bbondy added a commit that referenced this pull request Oct 17, 2018
Fixes crashes when downloading an item (repro'd with a .crx)
@bbondy
Copy link
Member

bbondy commented Oct 17, 2018

master: 7e4770a
0.57.x: c3b5264
0.56.x: daf9c85
0.55.x: cf050f4

bbondy added a commit that referenced this pull request Oct 17, 2018
Fixes crashes when downloading an item (repro'd with a .crx)
@bsclifton bsclifton deleted the maxk-fix-crash-downloading branch November 5, 2018 18:49
@bbondy bbondy added this to the 0.55.x - Release milestone Jan 14, 2019
@bbondy bbondy removed the 0.55.x label Jan 14, 2019
This was referenced Oct 16, 2019
fmarier pushed a commit that referenced this pull request Oct 29, 2019
Use brave-browser version and check for inconsistency with src/chrome/VERSION
petemill pushed a commit that referenced this pull request Jul 27, 2020
Use brave-browser version and check for inconsistency with src/chrome/VERSION
petemill pushed a commit that referenced this pull request Jul 28, 2020
Use brave-browser version and check for inconsistency with src/chrome/VERSION
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

brave attempting to download crx and crashes instead of installing extension
2 participants