-
Notifications
You must be signed in to change notification settings - Fork 879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds contribution queue #3658
Adds contribution queue #3658
Conversation
db8f72a
to
bbea531
Compare
marked it so that CI can do first pass |
bbea531
to
6e3ac12
Compare
@tmancey @kylehickinson not ready for a review yet |
e5f4c0e
to
617b42e
Compare
6c0875a
to
13ea7e4
Compare
// Make sure that balance is updated correctly | ||
{ | ||
const std::string result = ElementInnerText("[data-test-id='balance']"); | ||
LOG(ERROR) << "NEJC actual: " << result; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have it in for now as test is failing on CI, will remove at the end
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM++
ee61c0b
to
2253c1b
Compare
640974d
to
93d96bc
Compare
CI is failing with this issue brave/brave-browser#6515. Everything else passed |
Verified with
|
yup saw 6545 for some time now, already asked for any hints from other teams as my current theory is that it's related to chromium bump. 6545 is not related to this PR |
Not a conclusive test, but I did just run two auto contribute only tests (no monthly recurring tips) with the same build (0.73.8) and did not see the Maybe it's related to recurring tips? |
@LaurenWags not sure, it's for now random for me, don't have STR yet |
Resolves brave/brave-browser#6288
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.