Skip to content

Commit

Permalink
Enable system health.common desktop (#19057)
Browse files Browse the repository at this point in the history
  • Loading branch information
atuchin-m authored Jun 28, 2023
1 parent 5082864 commit dfcbdf0
Show file tree
Hide file tree
Showing 6 changed files with 55 additions and 2 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
diff --git a/telemetry/telemetry/internal/actions/action_runner.py b/telemetry/telemetry/internal/actions/action_runner.py
index 8d9e98ff1e546588f69935a688249b97fbb0992e..ca2912fa87beb576e35a0a5b453fd03b14d590fb 100644
--- a/telemetry/telemetry/internal/actions/action_runner.py
+++ b/telemetry/telemetry/internal/actions/action_runner.py
@@ -41,7 +41,7 @@ import py_utils

# Time to wait in seconds before requesting a memory dump in deterministic
# mode, thus allowing metric values to stabilize a bit.
-_MEMORY_DUMP_WAIT_TIME = 3
+_MEMORY_DUMP_WAIT_TIME = 10

# Time to wait in seconds after forcing garbage collection to allow its
# effects to propagate. Experimentally determined on an Android One device
8 changes: 8 additions & 0 deletions tools/perf/configs/dashboard/brave-mac-mini-m1-typical.json5
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,14 @@
{
"name": "system_health.memory_desktop",
"pageset-repeat": 20,
"stories": [
"load:chrome:blank",
"load:media:youtube:2018",
]
},
{
"name": "system_health.common_desktop",
"pageset-repeat": 20,
"stories": [
"load:chrome:blank",
"browse:news:hackernews:2020",
Expand Down
8 changes: 8 additions & 0 deletions tools/perf/configs/dashboard/brave-mac-mini-x64-typical.json5
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,14 @@
{
"name": "system_health.memory_desktop",
"pageset-repeat": 20,
"stories": [
"load:chrome:blank",
"load:media:youtube:2018",
]
},
{
"name": "system_health.common_desktop",
"pageset-repeat": 20,
"stories": [
"load:chrome:blank",
"browse:news:hackernews:2020",
Expand Down
8 changes: 8 additions & 0 deletions tools/perf/configs/dashboard/brave-typical.json5
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,14 @@
{
"name": "system_health.memory_desktop",
"pageset-repeat": 10,
"stories": [
"load:chrome:blank",
"load:media:youtube:2018",
]
},
{
"name": "system_health.common_desktop",
"pageset-repeat": 10,
"stories": [
"load:chrome:blank",
"browse:news:hackernews:2020",
Expand Down
10 changes: 9 additions & 1 deletion tools/perf/configs/dashboard/smoke-brave.json5
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,12 @@
]
},
{
"name": "speedometer2-chrome-health",
"name": "system_health.common_desktop",
"pageset-repeat": 1,
"stories": [
"load:chrome:blank",
"browse:news:hackernews:2020",
]
},
{
"name": "system_health.memory_desktop",
Expand All @@ -30,5 +34,9 @@
"load:media:youtube:2018",
]
},
{
"name": "speedometer2",
"pageset-repeat": 1,
},
]
}
10 changes: 9 additions & 1 deletion tools/perf/configs/dashboard/smoke-chrome.json5
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,12 @@
]
},
{
"name": "speedometer2-chrome-health",
"name": "system_health.common_desktop",
"pageset-repeat": 1,
"stories": [
"load:chrome:blank",
"browse:news:hackernews:2020",
]
},
{
"name": "system_health.memory_desktop",
Expand All @@ -30,5 +34,9 @@
"load:media:youtube:2018",
]
},
{
"name": "speedometer2",
"pageset-repeat": 1,
},
]
}

0 comments on commit dfcbdf0

Please sign in to comment.