Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable system health.common desktop #19057

Merged
merged 2 commits into from
Jun 28, 2023

Conversation

atuchin-m
Copy link
Collaborator

@atuchin-m atuchin-m commented Jun 27, 2023

Resolves brave/brave-browser#31329
For brave/brave-browser#30969

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@atuchin-m atuchin-m force-pushed the enable-system_health.common_desktop branch from bf90ebf to a392ba4 Compare June 27, 2023 10:44
@atuchin-m atuchin-m marked this pull request as ready for review June 28, 2023 08:51
@atuchin-m atuchin-m requested a review from a team as a code owner June 28, 2023 08:51
@atuchin-m atuchin-m requested a review from iefremov June 28, 2023 08:51
@atuchin-m atuchin-m merged commit dfcbdf0 into master Jun 28, 2023
@atuchin-m atuchin-m deleted the enable-system_health.common_desktop branch June 28, 2023 19:30
@github-actions github-actions bot added this to the 1.55.x - Nightly milestone Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants