Add ability to resolve ENS and Unstoppable domains to ethereum address #10447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yrliou
force-pushed
the
UD_ENS_new_wallet
branch
3 times, most recently
from
9371f10 to
b9f681d
Compare
bbondy
reviewed
Oct 13, 2021
| @@ -125,6 +145,13 @@ bool ContentHash(const std::string& domain, std::string* data) { | |||
| return ConcatHexStrings(hex_strings, data); | |||
| } | |||
|
|
|||
| bool Addr(const std::string& domain, std::string* data) { | |||
There was a problem hiding this comment.
You could add a test for this one and Get pretty easily in components/brave_wallet/browser/eth_data_builder_unittest.cc
bbondy
approved these changes
Oct 13, 2021
- Get eth_json_rpc_controller directly via browser context in decentralized_dns_network_delegate_helper. - Move logic of parsing result of ENS ContentHash & UD GetMany contract methods from decentralized_dns_network_delegate_helper into eth_json_rpc_controller and eth_response_parser. - Expose EnsResolverGetContentHash to callers directly and keep the process of getting resolver first as internal implementation defails of eth_json_rpc_controller. - Add helper methods for getting contract address by chain id. - Add ability for callers to specify chain_id when doing ENS/UD resolution. - Add RequestInternal to be able to override network_url when needed.
yrliou
force-pushed
the
UD_ENS_new_wallet
branch
from
b9f681d to
b35edba
Compare
|
CI all passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#18531
The first commit is mostly for doing a refactoring to make things easier, and resolve the bug we have right now where we incorrectly use wallet's network setting for browser URL bar address resolution. please see the commit message for all the things changed.
The second is adding two new APIs to resolve UD/ENS to eth addr.
The third commits are updating/adding unit tests.
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_tests,npm run lint,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan: