Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #19069 - IsWebstoreUpdateUrl should return true for kChromeWebstoreUpdateURL even when component-updater switch is set #10781

Merged
merged 1 commit into from
Nov 3, 2021

Conversation

jumde
Copy link
Contributor

@jumde jumde commented Oct 29, 2021

Resolves brave/brave-browser#19069

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Open Brave Browser with a clean profile and verify that all components are installed correctly.
  2. Navigate to: https://chrome.google.com/webstore/detail/google-translate/aapbdbdomjkkjkaonfhkkikfgjllcleb
  3. Add to Brave
  4. Navigate to brave://extensions/
  5. Click details
  6. Verify the source says Web Extensions Store

@jumde jumde requested a review from a team as a code owner October 29, 2021 19:32
@jumde jumde self-assigned this Oct 29, 2021
@jumde jumde force-pushed the extension_state_mismatch branch from 5c8d8f9 to 7d385a0 Compare November 2, 2021 17:25
@jumde jumde added the CI/run-network-audit Run network-audit label Nov 2, 2021
@jumde jumde force-pushed the extension_state_mismatch branch from 7d385a0 to 11844bb Compare November 2, 2021 20:46
…reUpdateURL even when component-updater switch is set
@jumde jumde force-pushed the extension_state_mismatch branch from 11844bb to e6fa4be Compare November 3, 2021 14:36
@jumde jumde merged commit 82a3309 into master Nov 3, 2021
@jumde jumde deleted the extension_state_mismatch branch November 3, 2021 17:51
@jumde jumde added this to the 1.33.x - Nightly milestone Nov 3, 2021
bsclifton pushed a commit that referenced this pull request Nov 17, 2021
Fix #19069 - IsWebstoreUpdateUrl should return true for kChromeWebstoreUpdateURL even when component-updater switch is set
@kjozwiak
Copy link
Member

Verification PASSED on Win 11 x64 using the following build:

Brave | 1.34.23 Chromium: 96.0.4664.45 (Official Build) nightly (64-bit)
-- | --
Revision | 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS | Windows 11 Version 21H2 (Build 22000.318)
Example Example
componentUpdated sourceExtensions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-network-audit Run network-audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Web Store Update URL Missing, causing source-attribution confusion
3 participants