Hide auto-contribute section in brave://settings when region is JP

[emerick]

Resolves brave/brave-browser#19355

Submitter Checklist:

• I confirm that no security/privacy review is needed, or that I have requested one
• There is a ticket for my issue
• Used Github auto-closing keywords in the PR description above
• Wrote a good PR/commit description
• Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
• Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
• Ran git rebase master (if needed)

Reviewer Checklist:

• A security review is not needed, or a link to one is included in the PR description
• New files have MPL-2.0 license header
• Adequate test coverage exists to prevent regressions
• Major classes, functions and non-trivial code blocks are well-commented
• Changes in component dependencies are properly reflected in gn
• Code follows the style guide
• Test plan is specified in PR before merging

After-merge Checklist:

• The associated issue milestone is set to the smallest version that the
  changes has landed on
• All relevant documentation has been updated, for instance:
  • https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
  • https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
  • https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
  • https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
  • https://github.com/brave/brave-browser/wiki/Custom-Headers
  • https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
  • https://github.com/brave/brave-browser/wiki/QA-Guide
  • https://github.com/brave/brave-browser/wiki/P3A

Test Plan:

JP Region

• Clean profile
• Run brave with --rewards=countryid=19024 option to simulate running in JP region
• Visit brave://settings
• Click on Rewards
• Click link in right pane to open Rewards panel
• Enable Rewards
• Verify that auto-contribution settings aren't shown in settings

Non-JP Region

• Clean profile
• Visit brave://settings
• Click on Rewards
• Click link in right pane to open Rewards panel
• Enable Rewards
• Verify that auto-contribution settings are shown in settings

[szilardszaloki]

Nit:

std::string external_wallet_type = rewards_service->GetExternalWalletType();
return RespondNow(OneArgument(base::Value(std::move(external_wallet_type))));

or even:

return RespondNow(OneArgument(base::Value(rewards_service->GetExternalWalletType())));

[emerick]

Good idea, I went with your second suggestion!

[zenparsing]

In this PR, "AC supported" is derived from the "current external wallet type". Although this is status quo, we might want to think about moving away from that and just surfacing "AC supported" as its own thing from the rewards service.

The primary advantage, to me, would be that we could get rid of the idea of "current external wallet type", which isn't really meaningful in the context of an unverified user and breaks down when there are more than one supported external wallet providers.

[emerick]

Restarting Mac CI (all other platforms passed).

[emerick]

All CI passed, ready to merge.

[stephendonner]

Verified PASSED using

Brave	1.34.20 Chromium: 96.0.4664.45 (Official Build) nightly (64-bit)
Revision	76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS	Windows 10 Version 20H2 (Build 19042.1348)

JP region

1. clean profile
2. launched Brave using --rewards-countryid=19024 to simulate running in JP region
3. opened brave://settings
4. clicked on Brave Rewards in the left pane
5. clicked the link in the right pane to open the Rewards panel
6. clicked on Start using Brave Rewards
7. clicked Skip for now
8. clicked Continue
9. clicked Do it later
10. dismissed the panel
11. looked at brave://settings/rewards

Confirmed there was no Auto-Contribution section under Brave Rewards
Additionally, confirmed no A-C on brave://rewards or the tips panel

example	example	example	example

Non-JP region

1. clean profile
2. launched Brave in en-US region
3. opened brave://settings
4. clicked on Brave Rewards in the left pane
5. clicked the link in the right pane to open the Rewards panel
6. clicked on Start using Brave Rewards
7. clicked Skip for now
8. clicked Continue
9. clicked Do it later
10. dismissed the panel
11. loaded duckduckgo.com and waited for auto-contribution to occur
12. looked at brave://settings/rewards

Confirmed there was an Auto-Contribution section under Brave Rewards
Additionally, confirmed an auto-contribution was scheduled for duckduckgo.com

example	example	example	example