Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set Brave as a default browser w/o system UI on Windows (uplift to 1.33.x) #11217

Merged
merged 2 commits into from
Nov 23, 2021
Merged

Set Brave as a default browser w/o system UI on Windows (uplift to 1.33.x) #11217

merged 2 commits into from
Nov 23, 2021

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Nov 22, 2021 •
edited by kjozwiak
Loading

Uplift of #11125 and #10879
Resolves brave/brave-browser#19466
Resolves brave/brave-browser#17558

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested review from a team as code owners November 22, 2021 17:08
@brave-builds brave-builds requested a review from a team November 22, 2021 17:08
@brave-builds brave-builds self-assigned this Nov 22, 2021
@brave-builds brave-builds added this to the 1.33.x - Beta milestone Nov 22, 2021
@simonhong simonhong force-pushed the pr11125_default_browser_win_1.33.x branch from e818b9c to 78f186a Compare November 23, 2021 01:42
@brave-builds brave-builds requested a review from a team as a code owner November 23, 2021 01:42
kjozwiak
kjozwiak approved these changes Nov 23, 2021
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.33.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #11125 (comment) & #10879 (comment).

@kjozwiak kjozwiak merged commit eb4168e into 1.33.x Nov 23, 2021
@kjozwiak kjozwiak deleted the pr11125_default_browser_win_1.33.x branch November 23, 2021 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
None yet
Projects
None yet
Milestone
1.33.x - Release
Development

Successfully merging this pull request may close these issues.
4 participants
@brave-builds @kjozwiak @simonhong @brave-browser-releases