Set Brave as a default browser w/o system UI on Windows

[simonhong]

Resolves brave/brave-browser#19466

Submitter Checklist:

• I confirm that no security/privacy review is needed, or that I have requested one
• There is a ticket for my issue
• Used Github auto-closing keywords in the PR description above
• Wrote a good PR/commit description
• Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
• Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
• Ran git rebase master (if needed)

Reviewer Checklist:

• A security review is not needed, or a link to one is included in the PR description
• New files have MPL-2.0 license header
• Adequate test coverage exists to prevent regressions
• Major classes, functions and non-trivial code blocks are well-commented
• Changes in component dependencies are properly reflected in gn
• Code follows the style guide
• Test plan is specified in PR before merging

After-merge Checklist:

• The associated issue milestone is set to the smallest version that the
  changes has landed on
• All relevant documentation has been updated, for instance:
  • https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
  • https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
  • https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
  • https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
  • https://github.com/brave/brave-browser/wiki/Custom-Headers
  • https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
  • https://github.com/brave/brave-browser/wiki/QA-Guide
  • https://github.com/brave/brave-browser/wiki/P3A

Test Plan:

Test 1

1. Set another browser as a default browser
2. Launch Brave and load brave://settings/getStarted
3. Click Make default button and this is set as a default browser immediately w/o launching system UI

Test 2

1. Launch browser with clean profile
2. Make default browser prompt (Show default browser dialog instead of infobar #7716)
3. Click Set as a default and check browser is set as a default browser w/o system UI

NOTE: This feature is only available from Win10 RS2. Older browser will work like chromium.

[kjozwiak]

Verification PASSED on Win 11 x64 using the following build:

Brave | 1.34.31 Chromium: 96.0.4664.45 (Official Build) nightly (64-bit)
-- | --
Revision | 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS | Windows 11 Version 21H2 (Build 22000.318)

Test Case #1

• Set Chrome as the default application via chrome://settings/defaultBrowser which launched Apps -> Default apps (as per the above, this is the system UI that we're avoiding)
• ensured that clicking Make Default via brave://settings/getStarted set Brave as the default browser without launching Apps -> Default apps (Windows system UI)
• ensured that Brave is set as the default under Apps -> Default apps

Chrome as default	Brave set default via settings	Set as default

Test Case #2

• Set Chrome as the default application via chrome://settings/defaultBrowser which launched Apps -> Default apps (as per the above, this is the system UI that we're avoiding)
• re-launched Brave 4 times to receive the Set Brave as your default browser modal and ensured that clicking on Set as default didn't launch Apps -> Default apps (Windows system UI)
• ensured that Brave is set as the default under Apps -> Default apps
• ensured that the Set Brave as your default browser modal doesn't re-appear after opening Brave 20 more times

Chrome as default	Brave default modal	Brave set default via settings	Set as default

---

Verification PASSED on Win 10 x64 using the following build:

Brave	1.34.31 Chromium: 96.0.4664.45 (Official Build) nightly (64-bit)
Revision	76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS	Windows 10 Version 20H2 (Build 19042.1348)

Test Case #1

• Set Edge as the default application via Settings -> Control Panel -> Default apps (as per the above, this is the system UI that we're avoiding)
• ensured that clicking Make Default via brave://settings/getStarted set Brave as the default browser without launching Apps -> Default apps (Windows system UI)
• ensured that Brave is set as the default under Apps -> Default apps

Edge as default	Brave set default via settings	Set as default

Test Case #2

• Set Edge as the default application via Settings -> Control Panel -> Default apps (as per the above, this is the system UI that we're avoiding)
• re-launched Brave 4 times to receive the Set Brave as your default browser modal and ensured that clicking on Set as default didn't launch Apps -> Default apps (Windows system UI)
• ensured that Brave is set as the default under Apps -> Default apps
• ensured that the Set Brave as your default browser modal doesn't re-appear after opening Brave 20 more times

Edge as default	Brave default modal	Brave set default via settings	Set as default

[bridiver]

these should always go in public

[goodov]

ha! I actually asked Simon to move it before private: (which he did), but missed the part that this class have protected: (kinda rare in Chromium). Should be more precise with wording 🙂 #11125 (comment)