Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove binance widget android 1.33.x (Uplift to 1.33.x) #11405

Closed
wants to merge 3 commits into from

Conversation

deeppandya
Copy link
Contributor

Uplift of #11148
Resolves brave/brave-browser#19546

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@deeppandya deeppandya added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Dec 3, 2021
@deeppandya deeppandya added this to the 1.33.x - Release milestone Dec 3, 2021
@deeppandya deeppandya requested a review from a team December 3, 2021 00:29
@deeppandya deeppandya self-assigned this Dec 3, 2021
@kjozwiak
Copy link
Member

kjozwiak commented Dec 3, 2021

Closing as per discussions with @bbondy & @deeppandya. We're going to implement something similar to desktop where users who are authenticated will get to keep the widget rather than removing/nuking it for everyone which is what #11148 does right now.

@kjozwiak kjozwiak closed this Dec 3, 2021
@kjozwiak kjozwiak removed this from the 1.33.x - Release milestone Dec 3, 2021
@kjozwiak kjozwiak removed CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Dec 3, 2021
@kjozwiak kjozwiak removed the request for review from a team December 3, 2021 03:20
@kjozwiak kjozwiak deleted the remove_binance_widget_android_1.33.x branch December 3, 2021 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants