Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove binance widget android 1.33.x (Uplift to 1.33.x) #11405

Closed
wants to merge 3 commits into from
Closed

Remove binance widget android 1.33.x (Uplift to 1.33.x) #11405

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1df97f4
Hide binance widget
deeppandya Nov 18, 2021
c1660a3
Remove binance widget related code
deeppandya Nov 18, 2021
7915c12
Resolve cherrypick issue
deeppandya Dec 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 0 additions & 50 deletions android/brave_java_resources.gni
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,44 +197,10 @@ brave_java_resources = [
"java/res/drawable-mdpi/verified_creator_large.png",
"java/res/drawable-mdpi/verified_disclosure.png",
"java/res/drawable-mdpi/yandex.png",
"java/res/drawable-nodpi/ada.png",
"java/res/drawable-nodpi/adx.png",
"java/res/drawable-nodpi/atom.png",
"java/res/drawable-nodpi/bat.png",
"java/res/drawable-nodpi/bch.png",
"java/res/drawable-nodpi/bnb.png",
"java/res/drawable-nodpi/btc.png",
"java/res/drawable-nodpi/busd.png",
"java/res/drawable-nodpi/dash.png",
"java/res/drawable-nodpi/doge.png",
"java/res/drawable-nodpi/dylan_malval_sea_min.webp",
"java/res/drawable-nodpi/eng.png",
"java/res/drawable-nodpi/enj.png",
"java/res/drawable-nodpi/eos.png",
"java/res/drawable-nodpi/etc.png",
"java/res/drawable-nodpi/eth.png",
"java/res/drawable-nodpi/fee_icon.png",
"java/res/drawable-nodpi/link.png",
"java/res/drawable-nodpi/loader0.png",
"java/res/drawable-nodpi/loader0_orange.png",
"java/res/drawable-nodpi/ltc.png",
"java/res/drawable-nodpi/matic.png",
"java/res/drawable-nodpi/nano.png",
"java/res/drawable-nodpi/ont.png",
"java/res/drawable-nodpi/pax.png",
"java/res/drawable-nodpi/rvn.png",
"java/res/drawable-nodpi/trx.png",
"java/res/drawable-nodpi/tusd.png",
"java/res/drawable-nodpi/usdc.png",
"java/res/drawable-nodpi/usdt.png",
"java/res/drawable-nodpi/vet.png",
"java/res/drawable-nodpi/xlm.png",
"java/res/drawable-nodpi/xrp.png",
"java/res/drawable-nodpi/xtz.png",
"java/res/drawable-nodpi/xvg.png",
"java/res/drawable-nodpi/zec.png",
"java/res/drawable-nodpi/zil.png",
"java/res/drawable-nodpi/zrx.png",
"java/res/drawable-xhdpi/add_funds.png",
"java/res/drawable-xhdpi/bat_logo.png",
"java/res/drawable-xhdpi/bat_unverified.png",
Expand Down Expand Up @@ -520,8 +486,6 @@ brave_java_resources = [
"java/res/drawable/bat_ads_logo_button.xml",
"java/res/drawable/bat_panel_gradient.xml",
"java/res/drawable/bat_rewards_summary_gradient.xml",
"java/res/drawable/binance_edittext.xml",
"java/res/drawable/binance_radio_button_selector.xml",
"java/res/drawable/blue_rounded_button.xml",
"java/res/drawable/blue_rounded_holo_button.xml",
"java/res/drawable/brave_badge_rewards_background_large.xml",
Expand Down Expand Up @@ -573,7 +537,6 @@ brave_java_resources = [
"java/res/drawable/ic_addresses.xml",
"java/res/drawable/ic_appearance.xml",
"java/res/drawable/ic_arrow_downward.xml",
"java/res/drawable/ic_arrow_drop_down_white.xml",
"java/res/drawable/ic_arrow_forward.xml",
"java/res/drawable/ic_back.xml",
"java/res/drawable/ic_background_bat.xml",
Expand All @@ -583,7 +546,6 @@ brave_java_resources = [
"java/res/drawable/ic_basic_check.xml",
"java/res/drawable/ic_bg.xml",
"java/res/drawable/ic_bg_video_playback.xml",
"java/res/drawable/ic_binance.xml",
"java/res/drawable/ic_brave.xml",
"java/res/drawable/ic_brave_logo.xml",
"java/res/drawable/ic_brave_vpn_graphic.xml",
Expand Down Expand Up @@ -689,7 +651,6 @@ brave_java_resources = [
"java/res/drawable/rounded_corners.xml",
"java/res/drawable/rounded_filled.xml",
"java/res/drawable/rounded_filled_bg_radius_12.xml",
"java/res/drawable/rounded_filled_binance.xml",
"java/res/drawable/rounded_holo_button.xml",
"java/res/drawable/rounded_shape.xml",
"java/res/drawable/rounded_wallet_edittext.xml",
Expand Down Expand Up @@ -735,11 +696,6 @@ brave_java_resources = [
"java/res/layout/activity_p3a_onboarding.xml",
"java/res/layout/activity_set_default_browser.xml",
"java/res/layout/approve_tx_bottom_sheet.xml",
"java/res/layout/binance_deposit_item.xml",
"java/res/layout/binance_deposit_layout.xml",
"java/res/layout/binance_spinner_dropdown_item.xml",
"java/res/layout/binance_spinner_item.xml",
"java/res/layout/binance_summary_item.xml",
"java/res/layout/bottom_control_container.xml",
"java/res/layout/bottom_toolbar.xml",
"java/res/layout/bottom_toolbar_browsing.xml",
Expand Down Expand Up @@ -796,21 +752,15 @@ brave_java_resources = [
"java/res/layout/brave_webrtc_policy_preference.xml",
"java/res/layout/bre_bottom_banner.xml",
"java/res/layout/copy_save_bottom_sheet.xml",
"java/res/layout/crypto_widget_layout.xml",
"java/res/layout/edit_visible_assets_bottom_sheet.xml",
"java/res/layout/fragment_accounts.xml",
"java/res/layout/fragment_backup_wallet.xml",
"java/res/layout/fragment_binance_buy.xml",
"java/res/layout/fragment_binance_convert.xml",
"java/res/layout/fragment_binance_deposit.xml",
"java/res/layout/fragment_binance_summary.xml",
"java/res/layout/fragment_brave_ads_onboarding.xml",
"java/res/layout/fragment_brave_rewards_onboarding.xml",
"java/res/layout/fragment_brave_vpn_confirm_dialog.xml",
"java/res/layout/fragment_brave_vpn_plan.xml",
"java/res/layout/fragment_cross_promotional_modal_dialog.xml",
"java/res/layout/fragment_crypto_wallet_onboarding.xml",
"java/res/layout/fragment_crypto_widget_bottom_sheet_dialog.xml",
"java/res/layout/fragment_onboarding_v2.xml",
"java/res/layout/fragment_portfolio.xml",
"java/res/layout/fragment_qr_code_share.xml",
Expand Down
16 changes: 0 additions & 16 deletions android/brave_java_sources.gni
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,22 +292,6 @@ brave_java_sources = [
"../../brave/android/java/org/chromium/chrome/browser/vpn/BraveVpnSupportActivity.java",
"../../brave/android/java/org/chromium/chrome/browser/vpn/BraveVpnUtils.java",
"../../brave/android/java/org/chromium/chrome/browser/vpn/InAppPurchaseWrapper.java",
"../../brave/android/java/org/chromium/chrome/browser/widget/crypto/binance/BinanceAccountBalance.java",
"../../brave/android/java/org/chromium/chrome/browser/widget/crypto/binance/BinanceActivity.java",
"../../brave/android/java/org/chromium/chrome/browser/widget/crypto/binance/BinanceBuyFragment.java",
"../../brave/android/java/org/chromium/chrome/browser/widget/crypto/binance/BinanceCoinNetworks.java",
"../../brave/android/java/org/chromium/chrome/browser/widget/crypto/binance/BinanceConvert.java",
"../../brave/android/java/org/chromium/chrome/browser/widget/crypto/binance/BinanceConvertFragment.java",
"../../brave/android/java/org/chromium/chrome/browser/widget/crypto/binance/BinanceDepositFragment.java",
"../../brave/android/java/org/chromium/chrome/browser/widget/crypto/binance/BinanceNativeWorker.java",
"../../brave/android/java/org/chromium/chrome/browser/widget/crypto/binance/BinanceObserver.java",
"../../brave/android/java/org/chromium/chrome/browser/widget/crypto/binance/BinanceSpinnerAdapter.java",
"../../brave/android/java/org/chromium/chrome/browser/widget/crypto/binance/BinanceSummaryFragment.java",
"../../brave/android/java/org/chromium/chrome/browser/widget/crypto/binance/BinanceWidgetManager.java",
"../../brave/android/java/org/chromium/chrome/browser/widget/crypto/binance/CoinNetworkModel.java",
"../../brave/android/java/org/chromium/chrome/browser/widget/crypto/binance/ConvertAsset.java",
"../../brave/android/java/org/chromium/chrome/browser/widget/crypto/binance/CryptoWidgetBottomSheetDialogFragment.java",
"../../brave/android/java/org/chromium/chrome/browser/widget/crypto/binance/CryptoWidgetTabAdapter.java",
]

brave_java_sources += brave_ads_java_sources
Expand Down
12 changes: 0 additions & 12 deletions android/java/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,18 +117,6 @@
android:screenOrientation="sensorPortrait"
tools:ignore="LockedOrientationActivity"/>

<activity
android:name="org.chromium.chrome.browser.widget.crypto.binance.BinanceActivity"
android:theme="@style/Theme.Chromium.Activity.Fullscreen"
android:exported="true">
<intent-filter>
<action android:name="android.intent.action.VIEW" />
<category android:name="android.intent.category.BROWSABLE" />
<category android:name="android.intent.category.DEFAULT" />
<data android:scheme="com.brave.binance" />
</intent-filter>
</activity>

<activity android:name="org.chromium.chrome.browser.settings.BraveSettingsActivity"
android:theme="@style/Theme.Chromium.Settings"
android:configChanges="orientation|keyboardHidden|keyboard|screenSize|mcc|mnc|screenLayout|smallestScreenSize"
Expand Down
10 changes: 0 additions & 10 deletions android/java/org/chromium/chrome/browser/app/BraveActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,8 +125,6 @@
import org.chromium.chrome.browser.vpn.BraveVpnProfileUtils;
import org.chromium.chrome.browser.vpn.BraveVpnUtils;
import org.chromium.chrome.browser.vpn.InAppPurchaseWrapper;
import org.chromium.chrome.browser.widget.crypto.binance.BinanceAccountBalance;
import org.chromium.chrome.browser.widget.crypto.binance.BinanceWidgetManager;
import org.chromium.components.bookmarks.BookmarkId;
import org.chromium.components.bookmarks.BookmarkType;
import org.chromium.components.embedder_support.util.UrlConstants;
Expand Down Expand Up @@ -490,14 +488,6 @@ public void finishNativeInitialization() {
RetentionNotificationUtil.scheduleNotification(this, RetentionNotificationUtil.DEFAULT_BROWSER_3);
OnboardingPrefManager.getInstance().setOneTimeNotificationStarted(true);
}
if (!TextUtils.isEmpty(BinanceWidgetManager.getInstance().getBinanceAccountBalance())) {
try {
BinanceWidgetManager.binanceAccountBalance = new BinanceAccountBalance(
BinanceWidgetManager.getInstance().getBinanceAccountBalance());
} catch (JSONException e) {
Log.e("NTP", e.getMessage());
}
}

if (PackageUtils.isFirstInstall(this)
&& SharedPreferencesManager.getInstance().readInt(
Expand Down
Loading