Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sync to setting menu #1157

Merged
merged 1 commit into from
Dec 20, 2018
Merged

Add sync to setting menu #1157

merged 1 commit into from
Dec 20, 2018

Conversation

darkdh
Copy link
Member

@darkdh darkdh commented Dec 20, 2018 •
edited
Loading

screen shot 2018-12-19 at 20 15 00

fix brave/brave-browser#2593

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

sync enabled

  1. Launch Brave without --disable-brave-sync
  2. Go to brave://settings/
  3. Click menu on top left
  4. There should be a sync item
  5. Click sync item should navigate to sync section

sync disabled

  1. Launch Brave with --disable-brave-sync
  2. Go to brave://settings/
  3. Click menu on top left
  4. There is no sync item

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@darkdh darkdh self-assigned this Dec 20, 2018
cezaraugusto
cezaraugusto approved these changes Dec 20, 2018
View reviewed changes
Copy link
Contributor

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@cezaraugusto cezaraugusto merged commit 00b65d0 into master Dec 20, 2018
@cezaraugusto cezaraugusto deleted the sync-setting-sidebar branch December 20, 2018 15:43
cezaraugusto added a commit that referenced this pull request Dec 20, 2018
@cezaraugusto
Merge pull request #1157 from brave/sync-setting-sidebar
95d0d47 
Add sync to setting menu
@cezaraugusto
Copy link
Contributor

cezaraugusto commented Dec 20, 2018 •
edited by darkdh
Loading

master 00b65d0
0.60.x 95d0d47
0.59.x f385f00

@rebron
Copy link
Collaborator

rebron commented Dec 20, 2018

Approving uplift-request for 0.59.x-beta. cc: @kjozwiak cc: @srirambv

darkdh pushed a commit that referenced this pull request Dec 20, 2018
@cezaraugusto @darkdh
Merge pull request #1157 from brave/sync-setting-sidebar
f385f00 
Add sync to setting menu
@GeetaSarvadnya GeetaSarvadnya mentioned this pull request Jan 3, 2019
Closed
@bbondy bbondy added this to the 0.59.x - Beta milestone Jan 14, 2019
@fmarier fmarier mentioned this pull request Oct 27, 2020
Merged
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cezaraugusto cezaraugusto cezaraugusto approved these changes

@bbondy bbondy bbondy approved these changes

Assignees

@darkdh darkdh

Labels
None yet
Projects
None yet
Milestone
0.59.x - Release
Development

Successfully merging this pull request may close these issues.

No Sync label in settings' sidebar
4 participants
@darkdh @cezaraugusto @rebron @bbondy