Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes icon fetching for unverified publishers #1200

Merged
merged 1 commit into from
Jan 4, 2019
Merged

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Jan 3, 2019

Resolves brave/brave-browser#2717

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

  • enable rewards
  • visit regular sites (non verified and verified) and make sure that image is displayed correctly for both of them in settings page and panel
  • visit youtube channels (non verified and verified) and make sure that we don't fetch/display icon for unverified publishers, where we display it for verified ones

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

Copy link
Contributor

@ryanml ryanml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ test plan works great

@NejcZdovc NejcZdovc merged commit c9c44c7 into master Jan 4, 2019
@NejcZdovc NejcZdovc deleted the icon-scraping branch January 4, 2019 06:53
NejcZdovc added a commit that referenced this pull request Jan 4, 2019
Removes icon fetching for unverified publishers
NejcZdovc added a commit that referenced this pull request Jan 4, 2019
Removes icon fetching for unverified publishers
NejcZdovc added a commit that referenced this pull request Jan 4, 2019
Removes icon fetching for unverified publishers
@bbondy bbondy added this to the 0.61.x - Nightly milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove icon fetching for unverified media publishers
3 participants