Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes icon fetching for unverified publishers #1208

Merged
merged 1 commit into from
Jan 4, 2019
Merged

Removes icon fetching for unverified publishers #1208

merged 1 commit into from
Jan 4, 2019

Conversation

NejcZdovc
Copy link
Contributor

Resolves brave/brave-browser#2717

Original PR: #1200

@NejcZdovc NejcZdovc self-assigned this Jan 4, 2019
@NejcZdovc
Merge pull request #1200 from brave/icon-scraping
693a820 
Removes icon fetching for unverified publishers
srirambv
srirambv approved these changes Jan 4, 2019
View reviewed changes
Copy link
Contributor

@srirambv srirambv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

kjozwiak
kjozwiak approved these changes Jan 4, 2019
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift request to 0.59.x approved as this needs to land in the 0.58.x Hotfix 2 that's slated next week 👍Please ensure that the appropriate issue(s) are moved into the correct milestone.

@NejcZdovc NejcZdovc merged commit cd79afd into 0.59.x Jan 4, 2019
@NejcZdovc NejcZdovc deleted the icon-scraping-59 branch January 4, 2019 08:23
@bbondy bbondy added this to the 0.59.x - Beta milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srirambv srirambv srirambv approved these changes

@kjozwiak kjozwiak kjozwiak approved these changes

@bbondy bbondy Awaiting requested review from bbondy

@bsclifton bsclifton Awaiting requested review from bsclifton

@rebron rebron Awaiting requested review from rebron

Assignees

@NejcZdovc NejcZdovc

Labels
feature/rewards
Projects
None yet
Milestone
0.59.x - Release
Development

Successfully merging this pull request may close these issues.
4 participants
@NejcZdovc @kjozwiak @srirambv @bbondy