Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensuring contribution does not process if rewards or a-c is off (0.60) #1214

Merged
merged 1 commit into from
Jan 5, 2019
Merged

Ensuring contribution does not process if rewards or a-c is off (0.60) #1214

merged 1 commit into from
Jan 5, 2019

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Jan 4, 2019

Fixes: brave/brave-browser#2804
Resolves brave/brave-browser#2815



Original PR: #1205

@ryanml
Merge pull request #1205 from brave/fix-2804
020caf4 
Ensuring contribution does not process if rewards or a-c is off
@ryanml ryanml self-assigned this Jan 4, 2019
@ryanml ryanml requested a review from NejcZdovc January 4, 2019 19:37
@ryanml ryanml changed the title Merge pull request #1205 from brave/fix-2804 Ensuring contribution does not process if rewards or a-c is off (0.60) Jan 4, 2019
@kjozwiak
Copy link
Member

kjozwiak commented Jan 5, 2019 •
edited
Loading

Uplifts for dev don't require an approval from one of the approvals mentioned under https://github.com/brave/brave-browser/wiki/Triage-Guidelines#uplift-approvers. You'll still need an approval, but you're not required to get one from the following folks:

Current approvers are @rebron @kjozwiak @Sri @bbondy @clifton (Slack usernames).

beta and release uplifts requires an approval from one of the above folks.

@NejcZdovc NejcZdovc merged commit dca61f3 into 0.60.x Jan 5, 2019
@NejcZdovc NejcZdovc deleted the 0.60.x-2804 branch January 5, 2019 04:18
@bbondy bbondy added this to the 0.60.x - Dev milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NejcZdovc NejcZdovc NejcZdovc approved these changes

@jasonrsadler jasonrsadler Awaiting requested review from jasonrsadler

Assignees

@ryanml ryanml

Labels
feature/rewards
Projects
None yet
Milestone
0.60.x - Release
Development

Successfully merging this pull request may close these issues.
4 participants
@ryanml @kjozwiak @NejcZdovc @bbondy