Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensuring contribution does not process if rewards or a-c is off (0.59) #1215

Merged
merged 1 commit into from
Jan 8, 2019

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Jan 4, 2019

Fixes: brave/brave-browser#2804
Resolves brave/brave-browser#2815



Original PR: #1205

Ensuring contribution does not process if rewards or a-c is off
@kjozwiak
Copy link
Member

kjozwiak commented Jan 5, 2019

@ryanml you'll need to add one of the approvals that's listed under https://github.com/brave/brave-browser/wiki/Triage-Guidelines#uplift-approvers as a reviewer to get this uplifted into 0.59.x:

Current approvers are @rebron @kjozwiak @Sri @bbondy @clifton (Slack usernames)

With the old process, we would search for uplift labels which made it easy to find uplift requests. However, with the new process, if one of the above approvals isn't added as a reviewer, we won't get any emails which will make it hard to find this request.

@ryanml ryanml requested a review from kjozwiak January 5, 2019 03:19
@NejcZdovc NejcZdovc requested review from bsclifton, bbondy, srirambv and rebron and removed request for NejcZdovc and jasonrsadler January 5, 2019 04:16
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift to 0.59.x approved after deliberating with @rebron & @bsclifton 👍 Please ensure that all appropriate issues are moved into the correct milestone.

@ryanml ryanml merged commit 1691e67 into 0.59.x Jan 8, 2019
@ryanml ryanml deleted the 0.59.x-2804 branch January 8, 2019 02:13
@bbondy bbondy added this to the 0.59.x - Beta milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants