Ensuring contribution does not process if rewards or a-c is off (0.58) #1216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensuring contribution does not process if rewards or a-c is off
|
@ryanml you'll need to add one of the approvals that's listed under https://github.com/brave/brave-browser/wiki/Triage-Guidelines#uplift-approvers as a reviewer to get this uplifted into With the old process, we would search for |
|
Got it, thanks @kjozwiak ! |
NejcZdovc
requested review from
bbondy,
bsclifton and
srirambv
and removed request for
NejcZdovc and
jasonrsadler
kjozwiak
approved these changes
Jan 7, 2019
There was a problem hiding this comment.
Uplift to 0.58.x approved after deliberating with @rebron & @bsclifton 👍 Please ensure that all appropriate issues are moved into the correct milestone.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: brave/brave-browser#2804
Resolves brave/brave-browser#2815
Original PR: #1205