Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add codesign requirements to match upstream (uplift to 1.36.x) #12435

Merged
merged 1 commit into from
Mar 1, 2022
Merged

add codesign requirements to match upstream (uplift to 1.36.x) #12435

merged 1 commit into from
Mar 1, 2022

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Feb 28, 2022 •
edited by kjozwiak
Loading

Uplift of #12418
Resolves brave/brave-browser#21302

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team February 28, 2022 22:44
@brave-builds brave-builds self-assigned this Feb 28, 2022
@brave-builds brave-builds added this to the 1.36.x - Release milestone Feb 28, 2022
kjozwiak
kjozwiak approved these changes Mar 1, 2022
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.36.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #12418 (comment) & #12418 (comment).

As per @bsclifton, the pylint warnings are non-blocking and will be fixed/addressed in a follow up. Getting this uplifted so we can start another 1.36.x RC.

@kjozwiak kjozwiak merged commit 5b2f00c into 1.36.x Mar 1, 2022
@kjozwiak kjozwiak deleted the pr12418_issues/21302_1.36.x branch March 1, 2022 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
None yet
Projects
None yet
Milestone
1.36.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@brave-builds @kjozwiak @brave-browser-releases