Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add codesign requirements to match upstream (uplift to 1.36.x) #12435

Merged
merged 1 commit into from
Mar 1, 2022
Merged

add codesign requirements to match upstream (uplift to 1.36.x) #12435

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions build/mac/BUILD.gn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,6 +290,7 @@ action("sign_app") {
unsigned_app_path,
provisioning_profile,
"$packaging_dir/app-entitlements.plist",
"//brave/script/signing_helper.py",
]

outputs = [ signed_app_path ]
Expand Down
8 changes: 8 additions & 0 deletions script/signing_helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,14 @@ def distributions(self):
""" Brave distribution """
return [model.Distribution(channel=brave_channel)]

@property
def codesign_requirements_outer_app(self):
return 'designated => identifier "' + self.base_bundle_id + '"'

@property
def codesign_requirements_basic(self):
return 'and anchor apple generic and certificate 1[field.1.2.840.113635.100.6.2.6] /* exists / and certificate leaf[field.1.2.840.113635.100.6.1.13] / exists */'

config_class = ConfigNonChromeBranded

if mac_provisioning_profile is not None:
Expand Down