Fixed preferred size calculation for connection states in flyout menu #13374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonhong
approved these changes
May 18, 2022
| @@ -4,6 +4,7 @@ | |||
| * You can obtain one at http://mozilla.org/MPL/2.0/. */ | |||
|
|
|||
| #include "brave/browser/ui/views/toolbar/brave_vpn_status_label.h" | |||
| #include <corecrt_math.h> | |||
bsclifton
added a commit
that referenced
this pull request
Sep 17, 2024
This is no longer needed; it was put in place with #13374 but recent changes in Chromium 129 have made this obsolete (and it causes recursion). See https://issues.chromium.org/issues/40232718 for more info Fixes brave/brave-browser#41084
24 tasks
bsclifton
added a commit
that referenced
this pull request
Sep 17, 2024
This is no longer needed; it was put in place with #13374 but recent changes in Chromium 129 have made this obsolete (and it causes recursion). See https://issues.chromium.org/issues/40232718 for more info Fixes brave/brave-browser#41084
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#22742
2022-05-18_16h25_47.mp4
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_tests,npm run lint,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan:
1.39.92Brave VPNConnect/Disconnectstate using various window sizes