Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CalculatePreferredSize from BraveVPNStatusLabel #25595

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented Sep 17, 2024

This code being deleted is no longer needed; it was put in place with #13374 but recent changes in Chromium 129 have made this obsolete (and it causes recursion).

See https://issues.chromium.org/issues/40232718 for more info

Fixes brave/brave-browser#41084

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

See brave/brave-browser#41084

This is no longer needed; it was put in place with
#13374 but recent changes in
Chromium 129 have made this obsolete (and it causes recursion).

See https://issues.chromium.org/issues/40232718 for more info

Fixes brave/brave-browser#41084
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton
Copy link
Member Author

Uplifted to 1.70,x with #25594

@bsclifton bsclifton merged commit ea7af3e into master Sep 17, 2024
18 checks passed
@bsclifton bsclifton deleted the bsc-fix-vpn-button-crash branch September 17, 2024 05:52
@github-actions github-actions bot added this to the 1.72.x - Nightly milestone Sep 17, 2024
brave-builds added a commit that referenced this pull request Sep 17, 2024
kjozwiak pushed a commit that referenced this pull request Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants