Enable Solana dApps support by default on desktop

[darkdh]

Resolves brave/brave-browser#23520
security: https://github.com/brave/security/issues/920

performance degradation has been resolved in #13679

Waiting for #13666

Submitter Checklist:

• I confirm that no security/privacy review is needed, or that I have requested one
• There is a ticket for my issue
• Used Github auto-closing keywords in the PR description above
• Wrote a good PR/commit description
• Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
• Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
• Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
• Ran git rebase master (if needed)

Reviewer Checklist:

• A security review is not needed, or a link to one is included in the PR description
• New files have MPL-2.0 license header
• Adequate test coverage exists to prevent regressions
• Major classes, functions and non-trivial code blocks are well-commented
• Changes in component dependencies are properly reflected in gn
• Code follows the style guide
• Test plan is specified in PR before merging

After-merge Checklist:

• The associated issue milestone is set to the smallest version that the
  changes has landed on
• All relevant documentation has been updated, for instance:
  • https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
  • https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
  • https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
  • https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
  • https://github.com/brave/brave-browser/wiki/Custom-Headers
  • https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
  • https://github.com/brave/brave-browser/wiki/QA-Guide
  • https://github.com/brave/brave-browser/wiki/P3A

Test Plan:

Follow https://github.com/darkdh/solana-provider-test#qa-test
and make sure Solana account is setup

Connect and disconnect

1. Click "Connect" button
2. Reject request when prompted, we should see error showing rejected
3. Click "Eagerly Connect" button
4. Request should be rejected automatically without asking because it doesn't have permission
5. Click "Connect" button and grant permission
6. We should see new entry in brave://settings/content/solana
7. Also event emitted like [connect] (address)
8. Click "Disconnect" button, we should see event emitted [disconnect] 👋
9. Click "Eagerly Connect" button
10. [connect] (address) should be emitted
11. Repeat step 1 to 10 with "(Request)" version

Connect and lock

1. Click "Connect" button and grant permission and disconnect
2. Lock wallet
3. Click "Eagerly Connect" button
4. Request will be rejected because it is locked
5. Click "Connect" button
6. And ignore unlock wallet prompt
7. Click "Connect" button again it will get rejected because it is waiting for previous connect to be unlocked
8. Unlock the wallet
9. [connect] address should be emitted

Transactions

Follow test plan in #13666

SignMessage

1. Connect first
2. Click "SignMessage" button
3. Reject the request, we should see [error] signMessage: {"code":4001,"message":"The user rejected the request."}
4. Click "SignMessage" button again
5. And we will see signature printed out (compare it with same seed phrase using Phantom, they should be the same)
6. Click "SignMessage (Hex display)" button and accept the request
7. Signature result should be same as step 5
8. Repeat step 1 to 7 with "Request" version

accountChangedEvent

1. Make sure there are two Solana accounts
2. Connect first with first account
3. Select second account and we will see [accountChanged] Switched unknown account
4. Reject the request and [accountChanged] Failed to re-connect: The user rejected the request. will be shown
5. Select first account, [accountChanged] Switched account to (account1) emitted
6. Select second account and grant permission
7. We should see

[accountChanged] Reconnected successfully
[connect] (account2)

[kdenhartog]

This is good to go. We've covered the critical concerns and are tracking the non-blocking issues as well from a security perspective. LGTM

Great work on this!

[darkdh]

web_discovery_project audit failure is not related to this PR
web_discovery_project.py