Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Merge pull request #13825 from brave/solana-dapps-default" #13981

Merged
merged 1 commit into from
Jun 28, 2022

Conversation

yrliou
Copy link
Member

@yrliou yrliou commented Jun 28, 2022

This reverts commit 40aa587, reversing
changes made to eb936e7.

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

This reverts commit 40aa587, reversing
changes made to eb936e7.
@yrliou yrliou requested a review from a team as a code owner June 28, 2022 02:25
@yrliou yrliou self-assigned this Jun 28, 2022
@yrliou yrliou requested a review from darkdh June 28, 2022 04:41
@yrliou yrliou merged commit 48f09e8 into master Jun 28, 2022
@yrliou yrliou deleted the disable_solana_provider branch June 28, 2022 05:02
@github-actions github-actions bot added this to the 1.42.x - Nightly milestone Jun 28, 2022
darkdh added a commit that referenced this pull request Jun 28, 2022
@darkdh darkdh mentioned this pull request Jun 28, 2022
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants