Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Confirmations UI integration #1509

Closed
wants to merge 6 commits into from

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Jan 30, 2019

Target PR: #1469

A few things need to be accomplished for this integration:

  • The client side state/react code should be updated to accommodate multiple grants (Settings/Panel)
  • The new ledger server response of a list of grants with a discerning type attribute (one for ads, one for regular grant claim) should be parsed and filled in to an updated state att grants_ appropriately.
  • Code in native-ledger, web-ui, and rewards service implementation should have its methods updated to handle a list of grants as opposed to a single one.

Visual preview:
screen shot 2019-01-30 at 2 54 11 am

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

cc: @jsecretan @tmancey @emerick

@ryanml
Copy link
Contributor Author

ryanml commented Jan 31, 2019

@tmancey @jsecretan was having some upstream issues working off of this PR while tracking the confirmations branch, I'm finishing this on another branch.

@ryanml ryanml closed this Jan 31, 2019
@ryanml ryanml deleted the issues/2912-0.62.x-grant-claim branch February 4, 2019 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants