Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes eTLD+1 always visible on Android #15574

Merged
merged 1 commit into from
Oct 20, 2022

Conversation

SergeyZhukovsky
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky commented Oct 20, 2022

Resolves brave/brave-browser#26155

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Visit https://long-extended-subdomain-name-containing-many-letters-and-dashes.badssl.com/ysigsgksgkskgslgsogslgslgslgslgslgsogsogsogslgsogsyosoys
On versions before the fix observe that visible text in the URL bar
Screenshot_20221020-144841_Brave - Nightly

On versions after the fix observe that
Screenshot_20221020-144816_Brave - Debug

@SergeyZhukovsky SergeyZhukovsky added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Oct 20, 2022
@SergeyZhukovsky SergeyZhukovsky self-assigned this Oct 20, 2022
Copy link
Contributor

@samartnik samartnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SergeyZhukovsky SergeyZhukovsky merged commit 2529b3b into master Oct 20, 2022
@SergeyZhukovsky SergeyZhukovsky deleted the android_url_bar_long_links branch October 20, 2022 21:06
@github-actions github-actions bot added this to the 1.47.x - Nightly milestone Oct 20, 2022
cdesouza-chromium pushed a commit that referenced this pull request Oct 27, 2022
This is adjustment for changes in master #15574
cdesouza-chromium pushed a commit that referenced this pull request Oct 28, 2022
This is adjustment for changes in master #15574
mkarolin pushed a commit that referenced this pull request Nov 4, 2022
This is adjustment for changes in master #15574
mkarolin pushed a commit that referenced this pull request Nov 14, 2022
This is adjustment for changes in master #15574
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Security] Make eTLD+1 always visible in the URL bar
3 participants