Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Brave News]: Move to a push based API instead of a pull based one. #16038

Merged
merged 16 commits into from
Nov 22, 2022
Merged

[Brave News]: Move to a push based API instead of a pull based one. #16038

merged 16 commits into from
Nov 22, 2022

Conversation

fallaciousreasoning
Copy link
Contributor

@fallaciousreasoning fallaciousreasoning commented Nov 21, 2022 •
edited
Loading

Resolves brave/brave-browser#26884

Screencast.from.2022-11-21.15-26-40.webm

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Open two the brave News Customize dialog in two separate tabs, side by side.
  2. Follow a source in one tab.
  3. The other tab should be updated
  4. Unfollow a source/channel
  5. The other tab should be updated.

@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Nov 21, 2022
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

sangwoo108
sangwoo108 approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@sangwoo108 sangwoo108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

components/brave_today/common/brave_news.mojom Outdated
// Browser-side handler
interface BraveNewsController {
// Gets the current locale.
GetLocale() => (string locale);

GetFeed() => (Feed feed);

// Deprecated by https://github.com/brave/brave-core/pull/16038. Use
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: indent?

components/brave_today/browser/brave_news_controller.cc Outdated Show resolved Hide resolved
components/brave_new_tab_ui/api/brave_news/magicCache.ts
@@ -0,0 +1,47 @@
// Copyright (c) 2022 The Brave Authors. All rights reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice abstraction through entire layers! 👍

sangwoo108
sangwoo108 approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@sangwoo108 sangwoo108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@fallaciousreasoning fallaciousreasoning merged commit fc5f308 into master Nov 22, 2022
@fallaciousreasoning fallaciousreasoning deleted the bn-v2-mojom branch November 22, 2022 22:56
@github-actions github-actions bot added this to the 1.47.x - Nightly milestone Nov 22, 2022
This was referenced Nov 30, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sangwoo108 sangwoo108 sangwoo108 approved these changes

@petemill petemill Awaiting requested review from petemill

Assignees

@fallaciousreasoning fallaciousreasoning

Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Milestone
1.47.x - Release
Development

Successfully merging this pull request may close these issues.

[Brave News]: If Brave News is open in multiple tabs, they should remain in sync
3 participants
@fallaciousreasoning @brave-builds @sangwoo108