-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Brave News] Fix bug where direct feeds didn't show up as followed #16086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonhong
approved these changes
Nov 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
While initially trying to test this for uplift, I encountered brave/brave-browser#27052, just FYI for now. |
Verified
|
Brave | 1.48.15 Chromium: 108.0.5359.62 (Official Build) nightly (x86_64) |
---|---|
Revision | 041930a89a990cfab0315a2d9f20d6429a4a67cf-refs/branch-heads/5359@{#938} |
OS | macOS Version 11.7.1 (Build 20G918) |
Steps:
- installed
1.48.15
- launched Brave
- opened
brave://flags
- confirmed no
Brave News button
flag exists - loaded
theatlantic.com
- clicked on the
RSS
-feed icon in the URL bar - clicked on
Best of the Atlantic
'sFollow
button - waited
Confirmed the Follow
/ Unfollow
button state is accurately reflected
brave://flags |
theatlantic.com |
Follow |
Unfollow |
---|---|---|---|
NOTE: logged brave/brave-browser#27052 while testing
Note: I think brave/brave-browser#27052 was introduced by #16038, so the fix for that will need an uplift too. |
fallaciousreasoning
added a commit
that referenced
this pull request
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up for #15963, which fixed it's original issue but broke the button toggle state.
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Best of the Atlantic