Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Brave News]: Notify tabs when there are updates to their feed. #16048

Merged
merged 7 commits into from
Nov 24, 2022

Conversation

fallaciousreasoning
Copy link
Contributor

@fallaciousreasoning fallaciousreasoning commented Nov 21, 2022

Resolves brave/brave-browser#26631

Screencast.from.2022-11-22.12-45-50.webm

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Unfollow a publisher
  2. The Load new content button should become visible.
  3. Refollow the publisher (the button should disappear).
  4. Unfollow and click the Load new content button. New content should be loaded and the button should disappear.

@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Nov 21, 2022
Base automatically changed from bn-v2-mojom to master November 22, 2022 22:56
Copy link
Contributor

@sangwoo108 sangwoo108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

} from '../../../../../out/Component/gen/brave/components/brave_today/common/brave_news.mojom.m'

export const addFeedListener = (listener: (feedHash: string) => void) =>
new (class implements FeedListenerInterface {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, didn't know that there's a class expression like this 👍

Copy link
Contributor Author

@fallaciousreasoning fallaciousreasoning Nov 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it's an anonymous class. JavaScript is full of funky features.

One that terrifies me is nested destructuring

let { foo: { bar: { hello: result = 7 } } } = { foo: { bar: { hello: 'world' } } }

@fallaciousreasoning fallaciousreasoning enabled auto-merge (squash) November 23, 2022 02:59
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@fallaciousreasoning fallaciousreasoning merged commit 7bee6e2 into master Nov 24, 2022
@fallaciousreasoning fallaciousreasoning deleted the bn-push-feed branch November 24, 2022 02:36
@github-actions github-actions bot added this to the 1.48.x - Nightly milestone Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Brave News Desktop: Following or unfollowing sources and channels should trigger an update banner
3 participants