-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Brave News]: Notify tabs when there are updates to their feed. #16048
Conversation
416a44c
to
11fff49
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
} from '../../../../../out/Component/gen/brave/components/brave_today/common/brave_news.mojom.m' | ||
|
||
export const addFeedListener = (listener: (feedHash: string) => void) => | ||
new (class implements FeedListenerInterface { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, didn't know that there's a class expression like this 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it's an anonymous class. JavaScript is full of funky features.
One that terrifies me is nested destructuring
let { foo: { bar: { hello: result = 7 } } } = { foo: { bar: { hello: 'world' } } }
f030184
to
aa729da
Compare
A Storybook has been deployed to preview UI for the latest push |
0c12f51
to
f18c17d
Compare
A Storybook has been deployed to preview UI for the latest push |
Resolves brave/brave-browser#26631
Screencast.from.2022-11-22.12-45-50.webm
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Load new content
button should become visible.Load new content
button. New content should be loaded and the button should disappear.