Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave News Desktop: Following or unfollowing sources and channels should trigger an update banner #26631

Closed
petemill opened this issue Nov 9, 2022 · 1 comment · Fixed by brave/brave-core#16048
Assignees
Labels

Comments

@petemill
Copy link
Member

petemill commented Nov 9, 2022

When channels or sources follows are changed in Customize, we should call the redux action checkForUpdate similar to how this happens in the redux setPublisherPref action.

note: That happens in a less than ideal manner since it waits for 3 seconds after making changes, hoping that the backend has re-fetches and re-built the feed in that time. Ideally we should have an event mechanism through a new mojom interface. We don't neccessarily need to improve that for this issue fix.

Steps

  • Open Customize
  • Follow a new channel
  • Close Customize
  • Actual: No "reload content" button pill is available
  • Expected: A "reload content" button pill is shown
@stephendonner
Copy link

Verified PASSED using

Brave 1.48.118 Chromium: 109.0.5414.80 (Official Build) beta (x86_64)
Revision 0f69b168d36a06cace4365e9f029fa987afa5633-refs/branch-heads/5414@{#1178}
OS macOS Version 11.7.2 (Build 20G1020)

Steps:

  1. installed 1.48.118
  2. launched Brave
  3. opened a new-tab page
  4. opted in to Brave News
  5. clicked on Customize
  6. unfollowed Top News
  7. followed Cars
  8. waited
  9. confirmed I saw Load new content
  10. clicked on the button
  11. confirmed I saw content from The Drive subbed in
example example example
Screen Shot 2023-01-09 at 4 22 11 PM Screen Shot 2023-01-09 at 4 22 16 PM Screen Shot 2023-01-09 at 4 22 22 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants