Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crash notifications is null on Android 6 #16090

Merged

Conversation

sujitacharya2005
Copy link
Contributor

@sujitacharya2005 sujitacharya2005 commented Nov 25, 2022

Resolves brave/brave-browser#26988

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. In android 6 device
  2. Open brave app settings

@sujitacharya2005 sujitacharya2005 added this to the 1.48.x - Nightly milestone Nov 25, 2022
@sujitacharya2005 sujitacharya2005 added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Nov 25, 2022
@sujitacharya2005 sujitacharya2005 force-pushed the 26988_crash_notifications_is_null_on_Android_6 branch from f6e19e8 to 81ba27b Compare November 25, 2022 18:23
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@github-actions
Copy link
Contributor

⚠️ PR head is an unsigned commit
commit: 81ba27b
reason: unsigned
Please follow the handbook to configure commit signing
cc: @sujitacharya2005

Copy link
Contributor

@deeppandya deeppandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sujitacharya2005 sujitacharya2005 merged commit 2f30fbd into master Nov 25, 2022
@sujitacharya2005 sujitacharya2005 deleted the 26988_crash_notifications_is_null_on_Android_6 branch November 25, 2022 19:33
brave-builds pushed a commit that referenced this pull request Nov 28, 2022
brave-builds pushed a commit that referenced this pull request Nov 28, 2022
brave-builds pushed a commit that referenced this pull request Nov 28, 2022
@LaurenWags
Copy link
Member

Verified on Asus Zenfone (x86) with Android 6 running 1.48.10.

Reproduced the issue using 1.46.129 and test plan from #16090 (comment), observed crash when tapping on "Settings" from 3 dots menu.

Confirmed no crash when using 1.48.10 and test plan from #16090 (comment).

1.46.129 1.48.10 1.48.10
1 46 129 1 48 10 1 1 48 10 2

tmancey added a commit that referenced this pull request Jul 9, 2023
Decouple Brave Ads conversions and resolve #16090 and #26834
tmancey added a commit that referenced this pull request Jul 10, 2023
Followup to "Decouple Brave Ads conversions and resolve #16090 and #26834"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

crash notifications is null on Android 6
4 participants