Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Followup to "Decouple Brave Ads conversions and resolve #16090 and #26834" #19205

Merged
merged 2 commits into from
Jul 10, 2023

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Jul 9, 2023

Resolves brave/brave-browser#31532

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@tmancey tmancey requested a review from a team as a code owner July 9, 2023 16:38
@tmancey tmancey self-assigned this Jul 9, 2023
@tmancey tmancey force-pushed the issues/31532 branch 3 times, most recently from 6131e4f to 130670b Compare July 10, 2023 12:38
@tmancey tmancey enabled auto-merge July 10, 2023 16:56
@tmancey tmancey merged commit 4664b6a into master Jul 10, 2023
@tmancey tmancey deleted the issues/31532 branch July 10, 2023 17:36
@github-actions github-actions bot added this to the 1.58.x - Nightly milestone Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Followup to "Decouple Brave Ads conversions and resolve #16090 and #26834"
2 participants